From mboxrd@z Thu Jan 1 00:00:00 1970 From: wub at partyvan.eu (Juuso Lapinlampi) Date: Thu, 12 May 2016 19:22:25 +0000 Subject: [PATCH 4/5] ui: Fix bad value for attribute action on form elements In-Reply-To: References: <1462989858-15825-1-git-send-email-wub@partyvan.eu> <1462989858-15825-5-git-send-email-wub@partyvan.eu> Message-ID: <20160512192225.GA24828@partyvan.eu> On Thu, May 12, 2016 at 05:41:50PM +0200, Jason A. Donenfeld wrote: > Could we instead just remove action? Does this work both in the case > of path/to/page and path/to/page/ ? Or in the former will this wind up > requesting path/to/.? I don't understand your question very well. I am pretty sure the action attribute is required in form. And yes, it works both ways. '.' means "this page", and that's what the UI code uses in many other places. The piece of code itself is used around branch switching next to the "switch button" near top of the document. I tested this in Chromium "developer" tools and the '.' should work without issues to keep the page the user was on. So in the end, you get directed to path/to/page or path/to/page/ depending on which you had. This just fixes a validation issue.