From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 2/2] css: consistent use of empty lines
Date: Wed, 29 Jun 2016 09:34:50 +0100 [thread overview]
Message-ID: <20160629083450.GD1605@john.keeping.me.uk> (raw)
In-Reply-To: <20160629073758.29304-2-list@eworm.de>
On Wed, Jun 29, 2016 at 09:37:58AM +0200, Christian Hesse wrote:
> From: Christian Hesse <mail at eworm.de>
>
> Signed-off-by: Christian Hesse <mail at eworm.de>
> ---
> cgit.css | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/cgit.css b/cgit.css
> index 983eac5..763a99e 100644
> --- a/cgit.css
> +++ b/cgit.css
[snip obviously correct changes]
> @@ -824,3 +830,4 @@ div#cgit table.ssdiff td.space {
> div#cgit table.ssdiff td.space div {
> min-height: 3em;
> }
> +
Is this adding a new line to the end of the file? I don't think we want
to do that (doesn't Git warn about it as a whitespace error?).
next prev parent reply other threads:[~2016-06-29 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 7:37 [PATCH 1/2] ui-log: color line changes list
2016-06-29 7:37 ` [PATCH 2/2] css: consistent use of empty lines list
2016-06-29 8:34 ` john [this message]
2016-06-29 8:48 ` list
2016-07-05 14:16 ` Jason
2016-07-01 22:02 ` [PATCH 1/2] ui-log: color line changes Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629083450.GD1605@john.keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).