From: list at eworm.de (Christian Hesse)
Subject: [PATCH 2/2] css: consistent use of empty lines
Date: Wed, 29 Jun 2016 10:48:35 +0200 [thread overview]
Message-ID: <20160629104835.50510e3e@leda.localdomain> (raw)
In-Reply-To: <20160629083450.GD1605@john.keeping.me.uk>
John Keeping <john at keeping.me.uk> on Wed, 2016/06/29 09:34:
> On Wed, Jun 29, 2016 at 09:37:58AM +0200, Christian Hesse wrote:
> > From: Christian Hesse <mail at eworm.de>
> >
> > Signed-off-by: Christian Hesse <mail at eworm.de>
> > ---
> > cgit.css | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/cgit.css b/cgit.css
> > index 983eac5..763a99e 100644
> > --- a/cgit.css
> > +++ b/cgit.css
> [snip obviously correct changes]
> > @@ -824,3 +830,4 @@ div#cgit table.ssdiff td.space {
> > div#cgit table.ssdiff td.space div {
> > min-height: 3em;
> > }
> > +
>
> Is this adding a new line to the end of the file?
Yes, it is.
> I don't think we want
> to do that (doesn't Git warn about it as a whitespace error?).
I tend to add a blank line at the end of my files. That makes sure I still
have a blank line when appending a new block.
Did not see any warnings from git... It did happily commit my changes.
But feel free to drop that change. ;)
--
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];)
putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20160629/46a8ef2a/attachment.asc>
next prev parent reply other threads:[~2016-06-29 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 7:37 [PATCH 1/2] ui-log: color line changes list
2016-06-29 7:37 ` [PATCH 2/2] css: consistent use of empty lines list
2016-06-29 8:34 ` john
2016-06-29 8:48 ` list [this message]
2016-07-05 14:16 ` Jason
2016-07-01 22:02 ` [PATCH 1/2] ui-log: color line changes Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629104835.50510e3e@leda.localdomain \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).