From: peter at colberg.org (Peter Colberg)
Subject: [PATCH v2] Link with -ldl on GNU/kFreeBSD
Date: Wed, 6 Jul 2016 17:30:39 -0400 [thread overview]
Message-ID: <20160706213038.GB16879@alcyone> (raw)
In-Reply-To: <1467424837-23086-1-git-send-email-peter@colberg.org>
On Fri, Jul 01, 2016 at 10:00:37PM -0400, Peter Colberg wrote:
> GNU/kFreeBSD uses the FreeBSD kernel with the GNU C library.
>
> Signed-off-by: Peter Colberg <peter at colberg.org>
> ---
> cgit.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cgit.mk b/cgit.mk
> index 369f309..8d4f5e0 100644
> --- a/cgit.mk
> +++ b/cgit.mk
> @@ -53,8 +53,8 @@ endif
>
> endif
>
> -# Add -ldl to linker flags on non-BSD systems.
> -ifeq ($(findstring BSD,$(uname_S)),)
> +# Add -ldl to linker flags on systems that commonly use GNU libc.
> +ifneq (,$(filter $(uname_S),Linux GNU/kFreeBSD))
> CGIT_LIBS += -ldl
> endif
>
> --
> 2.8.1
>
Any objections to merging this? While it is not a perfect solution,
it is better than the status quo and allows Debian to drop a patch.
Peter
next prev parent reply other threads:[~2016-07-06 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 22:55 [PATCH] " peter
2016-07-01 21:56 ` Jason
2016-07-02 1:33 ` peter
2016-07-02 1:50 ` peter
2016-07-02 2:00 ` [PATCH v2] " peter
2016-07-06 21:30 ` peter [this message]
2016-07-06 21:57 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706213038.GB16879@alcyone \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).