List for cgit developers and users
 help / color / mirror / Atom feed
From: richard.maw at gmail.com (Richard Maw)
Subject: [PATCH v3 16/21] Add namespace support to dumb-clone
Date: Mon,  1 Aug 2016 22:35:48 +0100	[thread overview]
Message-ID: <20160801213553.16807-17-richard.maw@gmail.com> (raw)
In-Reply-To: <20160801213553.16807-1-richard.maw@gmail.com>

This requires namespacing the HEAD symbolic ref
and the list of refs.

Sending HEAD required some tweaking,
since the file itself refers to a namespaced ref,
but we want to provide the ref with its namespace stripped off.

Signed-off-by: Richard Maw <richard.maw at gmail.com>
---
 ui-clone.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/ui-clone.c b/ui-clone.c
index 5f6606a..14380bf 100644
--- a/ui-clone.c
+++ b/ui-clone.c
@@ -85,7 +85,9 @@ void cgit_clone_info(void)
 	ctx.page.mimetype = "text/plain";
 	ctx.page.filename = "info/refs";
 	cgit_print_http_headers();
-	for_each_ref(print_ref_info, NULL);
+	/* NOTE: we pass an empty prefix because we want to enumerate everything
+	   not just all refs under $namespace/refs/ */
+	cgit_for_each_namespaced_ref_in("", print_ref_info, NULL);
 }
 
 void cgit_clone_objects(void)
@@ -105,5 +107,17 @@ void cgit_clone_objects(void)
 
 void cgit_clone_head(void)
 {
-	send_file(git_path("%s", "HEAD"));
+	unsigned char unused[20];
+	char *ref = cgit_namespaced_resolve_ref("HEAD", 0, unused, NULL);
+
+	if (!ref) {
+		cgit_print_error_page(404, "Not found", "Not found");
+		return;
+	}
+
+	ctx.page.mimetype = "application/octet-stream";
+	ctx.page.filename = xstrdup("HEAD");
+	cgit_print_http_headers();
+	htmlf("ref: %s\n", strip_namespace(ref));
+	free(ref);
 }
-- 
2.9.0



  parent reply	other threads:[~2016-08-01 21:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 21:35 [PATCH v3 00/21] Add namespace support to cgit richard.maw
2016-08-01 21:35 ` [PATCH v3 01/21] Return a copy of "master" when guessing defbranch fails richard.maw
2016-08-01 21:35 ` [PATCH v3 02/21] Fix archive generation richard.maw
2016-08-01 21:35 ` [PATCH v3 03/21] Add a wrapper for get_sha1 called cgit_get_sha1 richard.maw
2016-08-01 21:35 ` [PATCH v3 04/21] Parse repo.namespace richard.maw
2016-08-01 21:35 ` [PATCH v3 05/21] Print out parsed namespace on request richard.maw
2016-08-01 21:35 ` [PATCH v3 06/21] Set GIT_NAMESPACE when repo.namespace is provided richard.maw
2016-08-01 21:35 ` [PATCH v3 07/21] Add namespaced resolve ref helper richard.maw
2016-08-01 21:35 ` [PATCH v3 08/21] Add cgit_namespaced_dwim_ref for resolving short refs richard.maw
2016-08-01 21:35 ` [PATCH v3 09/21] Look up refs in namespace with cgit_get_sha1 richard.maw
2016-08-01 21:35 ` [PATCH v3 10/21] Use cgit_namespaced_dwim_ref for finding logs to show richard.maw
2016-08-01 21:35 ` [PATCH v3 11/21] Render commit decorations correctly richard.maw
2016-08-01 21:35 ` [PATCH v3 12/21] Guess the default branch based on current namespace richard.maw
2016-08-01 21:35 ` [PATCH v3 13/21] Add cgit_for_each_namespaced_ref_in helper richard.maw
2016-08-01 21:35 ` [PATCH v3 14/21] Find the default branch based on the contents of the namespace richard.maw
2016-08-01 21:35 ` [PATCH v3 15/21] Only display refs in current namespace richard.maw
2016-08-01 21:35 ` richard.maw [this message]
2016-08-01 21:35 ` [PATCH v3 17/21] Display notes from namespace richard.maw
2016-08-20 14:51   ` richard.maw
2016-08-01 21:35 ` [PATCH v3 18/21] Add documentation for repo.namespace richard.maw
2016-08-01 21:35 ` [PATCH v3 19/21] Allow agefile to be set per-repository richard.maw
2016-08-01 21:35 ` [PATCH v3 20/21] Update contrib script to update agefiles per namespace richard.maw
2016-08-01 21:35 ` [PATCH v3 21/21] Add documentation for repo.agefile richard.maw
2016-08-20 16:01 ` [PATCH v3 00/21] Add namespace support to cgit richard.maw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160801213553.16807-17-richard.maw@gmail.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).