From: john at keeping.me.uk (John Keeping)
Subject: [RFC] ui-repolist: Allow sections to be collapsible
Date: Tue, 9 Aug 2016 19:10:08 +0100 [thread overview]
Message-ID: <20160809181008.i6ck5zh3umxso53l@john.keeping.me.uk> (raw)
In-Reply-To: <c98807e8-789f-46be-8f69-470ab6a59f40@linaro.org>
On Mon, Aug 08, 2016 at 10:28:17PM -0500, Andy Doan wrote:
> On 08/08/2016 03:44 AM, John Keeping wrote:
> > I thought about this a bit more and I wonder if it would be more natural
> > to configure this with something like:
> >
> > section.collapse = 1
> >
> > We'd need to change the current "const char *section" into something
> > like:
> >
> > struct cgit_section {
> > unsigned int collapse : 1;
> > char name[];
> > };
> >
> > and I haven't thought too carefully about how exactly we parse the
> > "section.collapse" directive (e.g. does it apply to the current section
> > or does it apply to all future sections? The former seems more natural
> > initially but the latter would make it useful with section-from-path).
> >
> > What do you think?
>
> I'm a little confused, but its probably my lack of experience with cgit
> configuration capabilities. I currently take advantage "scan-path" to
> find everything so I was using something like:
>
> section-from-path=1
> scan-path=/srv/repositories
> section-collapse=pkg
> section-collapse=people
> section-collapse=ubuntu
>
> I'm not sure how I could accomplish that with your suggestion?
That might be covered by my "haven't thought too carefully", but I was
thinking of maybe setting "section.collapse = 1" and then any new
sections created by scan-path would have that bit set.
However, that would require you to have separate scan-path directives to
find the repositories that should collapse and those that shouldn't.
I think you've convinced me that listing section names in the config is
the way to go. But I still think we should invent the cgit_section
structure to hold the configuration, presumably accessed via a function
like:
struct cgit_section *get_or_create_section(const char *name)
next prev parent reply other threads:[~2016-08-09 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 19:33 andy.doan
2016-08-07 19:57 ` john
2016-08-08 3:02 ` andy.doan
2016-08-08 8:44 ` john
2016-08-09 3:28 ` andy.doan
2016-08-09 18:10 ` john [this message]
2016-08-09 21:53 ` andy.doan
2016-08-25 14:56 ` andy.doan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809181008.i6ck5zh3umxso53l@john.keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).