From: john at keeping.me.uk (John Keeping)
Subject: [PATCH] cgit: ignore SIGPIPE
Date: Sun, 2 Oct 2016 11:45:49 +0100 [thread overview]
Message-ID: <20161002104549.GA1997@john.keeping.me.uk> (raw)
In-Reply-To: <CAHmME9r1Jb+3D=8-+V7K9VTNtvTBbTfp1LLvO1fE8fNHgJenpw@mail.gmail.com>
On Sat, Oct 01, 2016 at 10:52:11PM +0200, Jason A. Donenfeld wrote:
> I see the utility of this with something like a highlight filter gone
> bad. But is it safe to do this in the context of an authentication
> filter? What's the failure behavior like once this patch is applied?
If we ignore SIGPIPE then we get an EPIPE error from write(2); in both
places that use write(2) we die if this happens.
So I think the only changes are our exit code and the fact that with
this patch we print an error message rather than exiting silently.
prev parent reply other threads:[~2016-10-02 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 14:38 SIGPIPE from syntax highlighting filter if highlight is not available vz-cgit
2016-10-01 11:33 ` john
2016-10-01 11:42 ` [PATCH] cgit: ignore SIGPIPE john
2016-10-01 20:52 ` Jason
2016-10-02 10:45 ` john [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161002104549.GA1997@john.keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).