List for cgit developers and users
 help / color / mirror / Atom feed
From: list at eworm.de (Christian Hesse)
Subject: [PATCH 02/10] ui-blob: replace 'unsigned char sha1[20]' with 'struct object_id oid'
Date: Tue, 4 Oct 2016 10:19:20 +0200	[thread overview]
Message-ID: <20161004101920.215d1db8@leda.localdomain> (raw)
In-Reply-To: <CAHmME9pzcdsag1L6BZENN-0ptfN5ObXgPPnPcs-R=KHhcrEq3A@mail.gmail.com>

"Jason A. Donenfeld" <Jason at zx2c4.com> on Tue, 2016/10/04 10:07:
> On Tue, Oct 4, 2016 at 9:51 AM, Christian Hesse <list at eworm.de> wrote:
> > +       hashcpy(walk_tree_ctx->matched_oid.hash, sha1);
> > +       if (sha1_object_info(oid.hash, &size) != OBJ_COMMIT)
> > +       type = sha1_object_info(oid.hash, &size);
> > +               type = sha1_object_info(oid.hash, &size);
> > +       buf = read_sha1_file(oid.hash, &type, &size);
> > +       type = sha1_object_info(oid.hash, &size);
> > +       buf = read_sha1_file(oid.hash, &type, &size);  
> 
> Presumably upstream git doesn't have an oid family of functions for these
> yet?

No. I think I have replaced everything possible.

John wrote a comment about changing format_notes(), but that is an upstream
function as well.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20161004/99d208ae/attachment.asc>


  reply	other threads:[~2016-10-04  8:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161004095050.29c7859b@leda.localdomain>
2016-10-04  7:51 ` [PATCH 01/10] cgit: " list
2016-10-04  7:51   ` [PATCH 02/10] ui-blob: " list
2016-10-04  8:07     ` Jason
2016-10-04  8:19       ` list [this message]
2016-10-04 18:34         ` john
2016-10-04 19:24           ` Jason
2016-10-04 19:48             ` list
2016-10-04  7:51   ` [PATCH 03/10] ui-commit: " list
2016-10-04  7:51   ` [PATCH 04/10] ui-log: replace get_sha1() with get_oid() list
2016-10-04  7:51   ` [PATCH 05/10] ui-patch: replace 'unsigned char sha1[20]' with 'struct object_id oid' list
2016-10-04  7:51   ` [PATCH 06/10] ui-plain: " list
2016-10-04  7:52   ` [PATCH 07/10] ui-shared: " list
2016-10-04  7:52   ` [PATCH 08/10] ui-snapshot: " list
2016-10-04  7:52   ` [PATCH 09/10] ui-tag: " list
2016-10-04  7:52   ` [PATCH 10/10] ui-tree: " list

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161004101920.215d1db8@leda.localdomain \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).