From mboxrd@z Thu Jan  1 00:00:00 1970
From: john at keeping.me.uk (John Keeping)
Date: Tue, 4 Oct 2016 19:34:34 +0100
Subject: [PATCH 02/10] ui-blob: replace 'unsigned char sha1[20]' with
 'struct object_id oid'
In-Reply-To: <20161004101920.215d1db8@leda.localdomain>
References: <20161004095050.29c7859b@leda.localdomain>
 <20161004075203.22115-1-list@eworm.de>
 <20161004075203.22115-2-list@eworm.de>
 <CAHmME9pzcdsag1L6BZENN-0ptfN5ObXgPPnPcs-R=KHhcrEq3A@mail.gmail.com>
 <20161004101920.215d1db8@leda.localdomain>
Message-ID: <20161004183434.GF1997@john.keeping.me.uk>

On Tue, Oct 04, 2016 at 10:19:20AM +0200, Christian Hesse wrote:
> "Jason A. Donenfeld" <Jason at zx2c4.com> on Tue, 2016/10/04 10:07:
> > On Tue, Oct 4, 2016 at 9:51 AM, Christian Hesse <list at eworm.de> wrote:
> > > +       hashcpy(walk_tree_ctx->matched_oid.hash, sha1);
> > > +       if (sha1_object_info(oid.hash, &size) != OBJ_COMMIT)
> > > +       type = sha1_object_info(oid.hash, &size);
> > > +               type = sha1_object_info(oid.hash, &size);
> > > +       buf = read_sha1_file(oid.hash, &type, &size);
> > > +       type = sha1_object_info(oid.hash, &size);
> > > +       buf = read_sha1_file(oid.hash, &type, &size);  
> > 
> > Presumably upstream git doesn't have an oid family of functions for these
> > yet?
> 
> No. I think I have replaced everything possible.
> 
> John wrote a comment about changing format_notes(), but that is an upstream
> function as well.

Yeah, I wasn't paying enough attention to where that functions was.
This series looks good to me, so:

Reviewed-by: John Keeping <john at keeping.me.uk>