List for cgit developers and users
 help / color / mirror / Atom feed
From: list at eworm.de (Christian Hesse)
Subject: Small patch makes cgit crash
Date: Fri, 7 Oct 2016 11:51:23 +0200	[thread overview]
Message-ID: <20161007115123.4cdb50d4@leda.localdomain> (raw)
In-Reply-To: <20161007113350.045550bc@leda.localdomain>

Christian Hesse <list at eworm.de> on Fri, 2016/10/07 11:33:
> Sylvain Rabot <sylvain at abstraction.fr> on Fri, 2016/10/07 11:27:
> > I've made a small patch to make cgit's summary layout look more like
> > gitweb's. It works but in some cases which I wasn't able to determine
> > the particulars it seems to crash and the clone url and the footer are
> > not displayed, e.g. :  
> 
> Does it crash with the patch applied only?

Ok, I can reproduce. For any reason info->subject is NULL when passed to
cgit_commit_link() in print_branch() (ui-refs.c, line 70).
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20161007/29d5954d/attachment.asc>


  parent reply	other threads:[~2016-10-07  9:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07  9:27 sylvain
2016-10-07  9:33 ` list
2016-10-07  9:37   ` sylvain
2016-10-07  9:51   ` list [this message]
2016-10-07 11:17     ` list
2016-10-07 11:54       ` sylvain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161007115123.4cdb50d4@leda.localdomain \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).