From mboxrd@z Thu Jan 1 00:00:00 1970 From: list at eworm.de (Christian Hesse) Date: Fri, 7 Oct 2016 23:25:55 +0200 Subject: [PATCH 1/1] ui-log: fix data corruption In-Reply-To: <20161007232123.5d7e8789@leda.localdomain> References: <20161007133526.2931-1-list@eworm.de> <20161007232123.5d7e8789@leda.localdomain> Message-ID: <20161007232555.437610b8@leda.localdomain> Christian Hesse on Fri, 2016/10/07 23:21: > "Jason A. Donenfeld" on Fri, 2016/10/07 21:43: > > Does this ever get freed, though? > > I ran cgit in valgrind with this patch applied. No changes in what is lost - > so looks like this is freed later on. Another thought on this... The issue reported by Sylvain Rabot shows that get_revision() can not get the same commit again. This is an indication we do free something we should not touch, no? -- main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];) putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);} -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 455 bytes Desc: OpenPGP digital signature URL: