List for cgit developers and users
 help / color / mirror / Atom feed
From: mricon at kernel.org (Konstantin Ryabitsev)
Subject: RFC: don't cache objects larger than X
Date: Wed, 12 Oct 2016 09:05:54 -0400	[thread overview]
Message-ID: <20161012130554.GA2200@gmail.com> (raw)
In-Reply-To: <CAHmME9p9V=etf2VX7szyFegOFZb1Bc=G-m3K00e0pwoGs+Kjgw@mail.gmail.com>

On Wed, Oct 12, 2016 at 01:22:34PM +0200, Jason A. Donenfeld wrote:
> I face this same problem, in fact. Unless somebody beats me to it, I'd
> be interested in giving this a stab.
> 
> One issue is that cache entries are currently "streamed" into the
> cache files, as they're produced. It's not trivially possible to know
> how big it's going to be beforehand. This means that the best we could
> do would be to just immediately unlink it after creation and printing.
> Would this be acceptable?

Is there any way of keeping track of how much was written? It seems like
it should be pretty simple to continuously check how much has been
written to the cache and abort writing if the cache file grows larger
than the configured maximum?

Best,
-- 
Konstantin Ryabitsev
Linux Foundation Collab Projects
Montr?al, Qu?bec
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20161012/9b93db7c/attachment.asc>


  reply	other threads:[~2016-10-12 13:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10 14:03 mricon
2016-10-12 11:22 ` Jason
2016-10-12 13:05   ` mricon [this message]
2016-10-17 17:56   ` lfleischer
2016-10-17 18:39     ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161012130554.GA2200@gmail.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).