List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: Linking cgit with Lua using -Wl,-E
Date: Sun, 23 Oct 2016 16:55:39 +0100	[thread overview]
Message-ID: <20161023155539.GB3542@john.keeping.me.uk> (raw)
In-Reply-To: <564914cc-2ae6-ad15-f40c-4f033788999c@aegee.org>

I assume it's possible to build a shared library; I get both shared and
static installed by my package manager.

It looks like there is some performance concern about using a shared
libary for Lua[1], but I doubt performance is critical for most uses
with CGit so I would recommend building and linking to the Lua shared
library if possible.

If you need to link to the static library, I think it will be safer to
use:

	-rdynamic -fvisibility=hidden

but that will still expose all of the symbols from libgit.a, which was
not designed to be used as a library by third-party code and thus does
not prefix its symbols, so you still have to be wary of symbol
collisions with other libraries.

[1] http://article.gmane.org/gmane.comp.lang.lua.general/18519

On Fri, Oct 21, 2016 at 09:54:23AM +0200, ????? ???????? wrote:
> liblua is linked statically. This is what you get, when you compile
> Lua from source (no liblua.so).
> 
> On 10/16/2016 01:55 PM, John Keeping wrote:
> > On Sun, Oct 16, 2016 at 07:30:08AM +0200, ????? ???????? wrote:
> >> on my system I wanted to link cgit with lua, so that lua can load the
> >> (lua)crypto.so module.  For this to work the symbol lua_gettop has to
> >> be exported by cgit.  I managed this by passing "-Wl,-E" to the
> >> linker, when compiling cgit.
> >
> > How are you linking to liblua?  I thought we normally linked that
> > dynamically so the symbol should be exported from the shared library
> > even if the cgit binary does not export symbols.
> >


  reply	other threads:[~2016-10-23 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-16  5:30 
2016-10-16 11:55 ` john
2016-10-21  7:54   ` 
2016-10-23 15:55     ` john [this message]
2016-11-06 10:13       ` 

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161023155539.GB3542@john.keeping.me.uk \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).