List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: Could snapshot links be named after git describe ?
Date: Sun, 23 Oct 2016 17:10:25 +0100	[thread overview]
Message-ID: <20161023161025.GC3542@john.keeping.me.uk> (raw)
In-Reply-To: <CADjtP1GniMzSb7ZC7Tw40iokTdes6sncx3iFiLFnZ_OoKsriKg@mail.gmail.com>

On Mon, Oct 10, 2016 at 11:04:11AM +0200, Sylvain Rabot wrote:
> Currently the snapshots and resulted downloaded files are named like
> this <project>-<branch|sha1>.<zip|tar.gz|tar.bz2>
> 
> I was wondering if they could be named using the git describe format
> instead. I think it would make more sens and be prettier.
> 
> Naming the file after the branch does not make much sens according to
> me as it could be any commit of the said branch at any given time and
> the full sha1 is not really useful.
> 
> <project>-$(git describe --abbrev=6).<zip|tar.gz|tar.bz2> seems the
> best to me. I find it really useful to have the last tag name and the
> number of commits since.

It turns out that this already works, at least for the fetching side.
For example for current tip of CGit's master branch:

	https://git.zx2c4.com/cgit/snapshot/cgit-v1.0-41-gc330a2e.tar.xz

However, switching to describe format when generating the links doesn't
look particularly straightforward since the code Git uses to do so is
not in libgit.a which CGit links against, so we'd either have to push
some refactoring patches upstream or reimplement the functionality.

I'm not a heavy user of the snapshot links except from scripts which
tend to just use a tag or SHA-1 so I don't intend to work on this, but
personally I wouldn't object to patches that cleanly implement this as a
switchable config option.


      reply	other threads:[~2016-10-23 16:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10  9:04 sylvain
2016-10-23 16:10 ` john [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161023161025.GC3542@john.keeping.me.uk \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).