From mboxrd@z Thu Jan  1 00:00:00 1970
From: petr.vorel at gmail.com (Petr Vorel)
Date: Thu, 24 Nov 2016 18:32:21 +0100
Subject: [PATCH v5 1/1] ui-shared: allow to split the repository link
In-Reply-To: <CAHmME9q_4uSaaXhrko8ZUJdge1CuO4_uukpUJwmPfAX0sTLniw@mail.gmail.com>
References: <1463067852-22123-1-git-send-email-petr.vorel@gmail.com>
 <CAHmME9q_4uSaaXhrko8ZUJdge1CuO4_uukpUJwmPfAX0sTLniw@mail.gmail.com>
Message-ID: <20161124173220.nle2w5p2yk34pgqz@x230>

Hi Jason,

> Sorry this has taken so long to review properly. Comments inline below:
Thanks a lot for your review. I really appreciate!

> On Thu, May 12, 2016 at 5:44 PM, Petr Vorel <petr.vorel at gmail.com> wrote:
> > This behaviour is not implemented for repositories which have
> > "repo.name" set different than "repo.url".

> That's annoying. Why? Is there a way to make the behavior consistant?
> Is gitweb inconsistent like this too?

Cgit allow user to have different link and name. This is valid configuration, but how to
cope with 3) and 4)? Don't have gitweb installed to test it.

# 1) ok
repo.url=section/subsection/myrepo
repo.path=/var/spool/cgit/myrepo/
repo.desc=url only

# 2) ok
repo.url=section/subsection/myrepo2
repo.path=/var/spool/cgit/myrepo2/
repo.desc=url only

# 3) different last part of path
repo.url=section/subsection/myrepo3
repo.name=section/subsection/myrepo3-different-name
repo.path=/var/spool/cgit/myrepo3/
repo.desc=path and name different: url=section/subsection/myrepo3, name=section/subsection/myrepo3-different-name

# 4) paths are completely different
repo.url=section/myrepo4
repo.name=section/subsection/myrepo4
repo.path=/var/spool/cgit/myrepo4/
repo.desc=path and name different: url=section/myrepo4, name=different-section/different-subsection/myrepo4

Any idea how to cope with it? I thought to use this feature only if repo.name and repo.url
are the same.

> > This feature is controlled by a new config variable:
> > "split-summary-repo-link" (disabled by default).

> I realize that John asked for a config variable in v3. But I do wonder
> if this really is so necessary. In what case would somebody _not_ want
> this behavior?
I don't think so, I'd also remove the config variable.

> > +split-summary-repo-link::
> > +       Flag which, when set to "1", will make cgit split the repository link in
> > +       the top of repository "summary" view. This emulates the same behaviour as
> > +       it's in gitweb. This behaviour is not implemented for repositories which
> > +       have "repo.name" set different than "repo.url". Default value: "0".

> Grammatical errors. No need to mention gitweb.


Kind regards,
Petr