List for cgit developers and users
 help / color / mirror / Atom feed
From: petr.vorel at gmail.com (Petr Vorel)
Subject: [PATCH v7 1/1] ui-shared: allow to split the repository link
Date: Sun, 12 Mar 2017 18:02:56 +0100	[thread overview]
Message-ID: <20170312170255.i4scz2cvlqwcsesb@x230> (raw)
In-Reply-To: <20170312153042.GL2102@john.keeping.me.uk>

Hi John,
> > Thanks for your review John. Are we there yet? :-)

> I just noticed one more thing...

> > +				html_link_open(cgit_repourl(name), NULL, NULL);
> The value returned by cgit_repourl() should be freed.

Thanks for info, fixed in v8.


Kind regards,
Petr


      reply	other threads:[~2017-03-12 17:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 23:36 petr.vorel
2017-03-12 15:03 ` john
2017-03-12 15:30 ` john
2017-03-12 17:02   ` petr.vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170312170255.i4scz2cvlqwcsesb@x230 \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).