List for cgit developers and users
 help / color / mirror / Atom feed
From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/1] git: update to v2.12.0
Date: Tue, 6 Jun 2017 16:12:16 +0200	[thread overview]
Message-ID: <20170606161216.1a860d01@leda> (raw)
In-Reply-To: <20170304122246.GB2102@john.keeping.me.uk>

John Keeping <john at keeping.me.uk> on Sat, 2017/03/04 12:22:
> On Wed, Mar 01, 2017 at 11:57:55AM +0100, Christian Hesse wrote:
> > From: Christian Hesse <mail at eworm.de>
> > 
> > Update to git version v2.12.0: With commit 8aee769f (pathspec: copy and
> > free owned memory) member 'match' of 'struct pathspec_item' is no longer
> > 'const char*' but just 'char*'.
>
> This feels a bit invasive for a change that just affects pathspec_item.
> Can't we keep most of CGit's API the same (and keep prefixes "const")
> and just adjust at the lowest level?
> 
> Maybe something like this instead?

Sorry for the late answer...

Probably makes sense. I have an alternative branch that looks similar to
your patch. ;)

As you sent this first... Want to rebase for git v2.13.1?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20170606/1b0eb03d/attachment.asc>


      reply	other threads:[~2017-06-06 14:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01 10:57 list
2017-03-04 12:22 ` john
2017-06-06 14:12   ` list [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170606161216.1a860d01@leda \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).