List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH 1/1] ui-repolist: remove unused variable
@ 2017-06-06 14:14 list
  2017-07-22 11:10 ` john
  2017-07-26  9:41 ` lfleischer
  0 siblings, 2 replies; 6+ messages in thread
From: list @ 2017-06-06 14:14 UTC (permalink / raw)


From: Christian Hesse <mail at eworm.de>

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 ui-repolist.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui-repolist.c b/ui-repolist.c
index 20a4f56..7272e87 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -225,7 +225,6 @@ static int sort_section(const void *a, const void *b)
 	const struct cgit_repo *r1 = a;
 	const struct cgit_repo *r2 = b;
 	int result;
-	time_t t;
 
 	result = cmp(r1->section, r2->section);
 	if (!result) {
-- 
2.13.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ui-repolist: remove unused variable
  2017-06-06 14:14 [PATCH 1/1] ui-repolist: remove unused variable list
@ 2017-07-22 11:10 ` john
  2017-07-26  9:41 ` lfleischer
  1 sibling, 0 replies; 6+ messages in thread
From: john @ 2017-07-22 11:10 UTC (permalink / raw)


On Tue, Jun 06, 2017 at 04:14:47PM +0200, Christian Hesse wrote:
> From: Christian Hesse <mail at eworm.de>
> 
> Signed-off-by: Christian Hesse <mail at eworm.de>

Reviewed-by: John Keeping <john at keeping.me.uk>
Fixes: 87c4748 (ui-repolist: properly sort by age, 2017-03-30)

> ---
>  ui-repolist.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ui-repolist.c b/ui-repolist.c
> index 20a4f56..7272e87 100644
> --- a/ui-repolist.c
> +++ b/ui-repolist.c
> @@ -225,7 +225,6 @@ static int sort_section(const void *a, const void *b)
>  	const struct cgit_repo *r1 = a;
>  	const struct cgit_repo *r2 = b;
>  	int result;
> -	time_t t;
>  
>  	result = cmp(r1->section, r2->section);
>  	if (!result) {
> -- 
> 2.13.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ui-repolist: remove unused variable
  2017-06-06 14:14 [PATCH 1/1] ui-repolist: remove unused variable list
  2017-07-22 11:10 ` john
@ 2017-07-26  9:41 ` lfleischer
  2017-07-26 18:34   ` list
  1 sibling, 1 reply; 6+ messages in thread
From: lfleischer @ 2017-07-26  9:41 UTC (permalink / raw)


On Tue, 06 Jun 2017 at 16:14:47, Christian Hesse wrote:
> From: Christian Hesse <mail at eworm.de>
> 
> Signed-off-by: Christian Hesse <mail at eworm.de>
> ---
>  ui-repolist.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ui-repolist.c b/ui-repolist.c
> index 20a4f56..7272e87 100644
> --- a/ui-repolist.c
> +++ b/ui-repolist.c
> @@ -225,7 +225,6 @@ static int sort_section(const void *a, const void *b)
>         const struct cgit_repo *r1 = a;
>         const struct cgit_repo *r2 = b;
>         int result;
> -       time_t t;
> [...]

Looks good to me. I already posted pretty much the same patch (and
queued it on lf/for-jason) back in April, though [1].

Jason, any chance you can go through our for-jason branches and merge
them anytime soon?

Regards,
Lukas

[1] https://lists.zx2c4.com/pipermail/cgit/2017-April/003532.html


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ui-repolist: remove unused variable
  2017-07-26  9:41 ` lfleischer
@ 2017-07-26 18:34   ` list
  2017-07-26 23:03     ` Jason
  0 siblings, 1 reply; 6+ messages in thread
From: list @ 2017-07-26 18:34 UTC (permalink / raw)


Lukas Fleischer <lfleischer at lfos.de> on Wed, 2017/07/26 11:41:
> On Tue, 06 Jun 2017 at 16:14:47, Christian Hesse wrote:
> > From: Christian Hesse <mail at eworm.de>
> > 
> > Signed-off-by: Christian Hesse <mail at eworm.de>
> > ---
> >  ui-repolist.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/ui-repolist.c b/ui-repolist.c
> > index 20a4f56..7272e87 100644
> > --- a/ui-repolist.c
> > +++ b/ui-repolist.c
> > @@ -225,7 +225,6 @@ static int sort_section(const void *a, const void *b)
> >         const struct cgit_repo *r1 = a;
> >         const struct cgit_repo *r2 = b;
> >         int result;
> > -       time_t t;
> > [...]  
> 
> Looks good to me. I already posted pretty much the same patch (and
> queued it on lf/for-jason) back in April, though [1].

Sorry, missed that. So... Review and signed-off by me (and John ;).

> Jason, any chance you can go through our for-jason branches and merge
> them anytime soon?

Yes, please!
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20170726/ce0120e1/attachment.asc>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ui-repolist: remove unused variable
  2017-07-26 18:34   ` list
@ 2017-07-26 23:03     ` Jason
  2017-08-04 18:31       ` list
  0 siblings, 1 reply; 6+ messages in thread
From: Jason @ 2017-07-26 23:03 UTC (permalink / raw)


On Wed, Jul 26, 2017 at 8:34 PM, Christian Hesse <list at eworm.de> wrote:
>> Jason, any chance you can go through our for-jason branches and merge
>> them anytime soon?
>
> Yes, please!

Absolutely. I'm finishing up a time consuming job this week, and
mid-next week, I'll start merging.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ui-repolist: remove unused variable
  2017-07-26 23:03     ` Jason
@ 2017-08-04 18:31       ` list
  0 siblings, 0 replies; 6+ messages in thread
From: list @ 2017-08-04 18:31 UTC (permalink / raw)


"Jason A. Donenfeld" <Jason at zx2c4.com> on Thu, 2017/07/27 01:03:
> On Wed, Jul 26, 2017 at 8:34 PM, Christian Hesse <list at eworm.de> wrote:
> >> Jason, any chance you can go through our for-jason branches and merge
> >> them anytime soon?  
> >
> > Yes, please!  
> 
> Absolutely. I'm finishing up a time consuming job this week, and
> mid-next week, I'll start merging.

Any news on this? :D
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20170804/485f9e05/attachment.asc>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-08-04 18:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-06 14:14 [PATCH 1/1] ui-repolist: remove unused variable list
2017-07-22 11:10 ` john
2017-07-26  9:41 ` lfleischer
2017-07-26 18:34   ` list
2017-07-26 23:03     ` Jason
2017-08-04 18:31       ` list

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).