From: john at keeping.me.uk (John Keeping)
Subject: cgit segfaults
Date: Wed, 16 Aug 2017 09:36:28 +0100 [thread overview]
Message-ID: <20170816083628.GC1987@john.keeping.me.uk> (raw)
In-Reply-To: <20170816012652.00e95163@home.rlworkman.net>
On Wed, Aug 16, 2017 at 01:26:52AM -0500, Robby Workman wrote:
> We're running cgit-1.1 with git-2.10.4 at https://git.slackbuilds.org and are seeing
> some reproducible segfaults.
>
> root at git:/var/log# dmesg -T
> [Wed Aug 16 01:14:23 2017] traps: cgit.cgi[2210] general protection ip:4515bd sp:7ffd787a9470 error:0 in cgit.cgi[400000+103000]
>
> This can be reliably triggered (i.e. every time) with at least one particular link (I'll share it
> privately with cgit devs, but since I don't know if there's any security impact, I'm not going
> to put it out on the list as yet).
>
> I've applied 1b4ef6783a71962f8b5da3a23f283 and c699866699411346c5dba4064575
> from git master since they appeared to address some segfaults, but apparently they were
> unrelated to whatever it is that we're seeing.
>
> Aside from (obviously) sharing the reproducer, any tips on debugging this? We of course
> have a strong preference for debugging tips that don't impact services on the machine,
> but if needed, we'll do what we have to do...
You can run cgit from the command line with your config and the URL
using something like:
CGIT_CONFIG=/path/to/cgitrc QUERY_STRING=url=cgit/repo/... cgit
This is what the tests do in tests/setup.sh::cgit_url().
That should allow you to build a debug binary and reproduce under that
without a webserver involved, which means you can run under gdb or
valgrind.
next prev parent reply other threads:[~2017-08-16 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 6:26 rworkman
2017-08-16 8:36 ` john [this message]
2017-08-24 6:18 ` rworkman
2017-08-24 8:12 ` john
2017-08-24 11:39 ` rworkman
2017-08-25 0:37 ` rworkman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816083628.GC1987@john.keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).