List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: [PATCH] Use https for submodule
Date: Tue, 19 Sep 2017 20:18:07 +0100	[thread overview]
Message-ID: <20170919191807.GG1601@john.keeping.me.uk> (raw)
In-Reply-To: <20170918200943.GA18534@dev.danweeks.net>

Please make use of the commit message to explain why this is a good
change.

On Mon, Sep 18, 2017 at 04:09:53PM -0400, Daniel M. Weeks wrote:
> Signed-off-by: Daniel M. Weeks <dan at danweeks.net>

With a more comprehensive commit message,

Reviewed-by: John Keeping <john at keeping.me.uk>

> ---
>  .gitmodules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitmodules b/.gitmodules
> index 1daea94..5c6ecb4 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,3 +1,3 @@
>  [submodule "git"]
> -	url = git://git.kernel.org/pub/scm/git/git.git
> +	url = https://git.kernel.org/pub/scm/git/git.git
>  	path = git


  reply	other threads:[~2017-09-19 19:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-18 20:09 dan
2017-09-19 19:18 ` john [this message]
2017-09-19 19:59   ` i

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170919191807.GG1601@john.keeping.me.uk \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).