From mboxrd@z Thu Jan 1 00:00:00 1970 From: john at keeping.me.uk (John Keeping) Date: Sat, 30 Sep 2017 13:00:17 +0100 Subject: [PATCH 3/5] ui-shared: make a char* parameter const In-Reply-To: <20170927224331.26494-4-whydoubt@gmail.com> References: <20170923033848.5922-1-whydoubt@gmail.com> <20170927224331.26494-1-whydoubt@gmail.com> <20170927224331.26494-4-whydoubt@gmail.com> Message-ID: <20170930120017.GC2327@john.keeping.me.uk> On Wed, Sep 27, 2017 at 05:43:29PM -0500, Jeff Smith wrote: > All cgit_xxx_link functions take const char* for the 'name' parameter, > except for cgit_commit_link, which takes a char* and subsequently > modifies the contents. Avoiding the content changes, and making it > const char* will avoid the need to make copies of const char* strings > being passed to cgit_commit_link. > > Signed-off-by: Jeff Smith Reviewed-by: John Keeping > --- > ui-shared.c | 19 ++++++++----------- > ui-shared.h | 2 +- > 2 files changed, 9 insertions(+), 12 deletions(-)