From mboxrd@z Thu Jan 1 00:00:00 1970 From: john at keeping.me.uk (John Keeping) Date: Sat, 30 Sep 2017 13:10:36 +0100 Subject: [PATCH 0/5] Add ui-blame In-Reply-To: <20170927224331.26494-1-whydoubt@gmail.com> References: <20170923033848.5922-1-whydoubt@gmail.com> <20170927224331.26494-1-whydoubt@gmail.com> Message-ID: <20170930121036.GC25019@john.keeping.me.uk> On Wed, Sep 27, 2017 at 05:43:26PM -0500, Jeff Smith wrote: > I split git blame functionality into libgit, and the changes were > accepted upstream and are a part of git 2.14. Now that the git > infrastructure is in place, here is what is needed for cgit to make use > of it. > > Since RFCv2: > . Re-ordered and squashed some of the patches > . Used cgit's commitinfo structure > . Factored set_title_from_path out to ui-shared > . Made cgit_commit_link's first parameter const char* > . Disabled the feature by default > . Simplified changes to html_ntxt / html_txt > > Jeff Smith (5): > html: html_ntxt with no ellipsis > ui-tree: move set_title_from_path to ui-shared > ui-shared: make a char* parameter const > ui-blame: add blame UI > ui-tree: link to blame UI if enabled This looks pretty good now. I've sent some comments on a couple of patches, but the only one I think is important is using (s)size_t for html_nxt in patch 1.