List for cgit developers and users
 help / color / mirror / Atom feed
From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/1] print git version string in footer
Date: Mon, 4 Jun 2018 22:59:46 +0200	[thread overview]
Message-ID: <20180604225946.31baef8b@leda> (raw)
In-Reply-To: <CAHmME9qSq4R83oaptpHPXhyta79sknR3Qr5xe5JoMS1xeBvZJQ@mail.gmail.com>

"Jason A. Donenfeld" <Jason at zx2c4.com> on Mon, 2018/06/04 22:51:
> Hey Christian,

Hey Jason,
 
> I like this idea and I'll probably merge it, because it seems handy.
> On the other hand, there's some argument to be made for not wearing
> your security bugs on your sleeves by revealing version numbers by
> default. I'm wondering what motivated it for you, though.

Usually it is me who updates the git submodules. Often I run a local cgit
build with custom commits/patches. Sometimes I wonder what git version it was
built with. :-p So I decided to give it a try and added the version to footer.

I thought about security as well, but I do not think this is a big issue: Who
ever has the cgit version can look up the git version anyway. (Except for
builds from git with changed submodule).

On the other hand this brings potential security issues to the
administrators eyes... I think it is worth merging.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20180604/88140ea7/attachment-0001.asc>


  reply	other threads:[~2018-06-04 20:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 20:29 list
2018-06-04 20:51 ` Jason
2018-06-04 20:59   ` list [this message]
2018-06-04 21:02   ` konstantin
2018-06-05 14:46 ` list
2018-06-05 15:08   ` [PATCH v2 " list
2018-06-06  6:24     ` [PATCH v3 " list
2018-06-06 12:34       ` Jason
2018-06-06 21:28         ` list

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180604225946.31baef8b@leda \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).