From: list at eworm.de (Christian Hesse)
Subject: Custom snapshot prefix & Snapshot signatures
Date: Thu, 7 Jun 2018 14:12:51 +0200 [thread overview]
Message-ID: <20180607141251.67607d90@leda> (raw)
Hello everybody,
I missed to reply in time and my mail client decided to purge old mails from
my mailing list folders. (Well, I told it to do so regularly.)
So breaking the threads and reviewing in this mail. Sorry!
First of all let me say that I really love this! The snapshot signatures
feature allows to get rid of uploading static tarballs and signatures,
handling everything from your command line with git. Thanks a lot for your
marvelous work, John!
I do agree with Konstantin, though: Binary compressed data may change over
time with more recent algorithms. So I will reply with an extra patch that
allows to push tar signatures to git notes that can be downloaded for
compressed tar snapshots.
Custom snapshot prefix [0]:
John Keeping (3):
ui-shared: pass repo object to print_snapshot_links()
ui-snapshot: pass repo into get_ref_from_filename()
Add "snapshot-prefix" repo configuration
All these look good to me. Please add my Reviewed-by!
Snapshot signatures [1]:
John Keeping (7):
ui-refs: remove unnecessary sanity check
ui-shared: remove unused parameter
ui-shared: rename parameter to cgit_print_snapshot_links()
ui-shared: use the same snapshot logic as ui-refs
ui-shared: pass separator in to cgit_print_snapshot_links()
ui-refs: use shared function to print tag downloads
All these look good to me. Please add my Reviewed-by!
snapshot: support archive signatures
> @@ -129,6 +154,39 @@ static int make_snapshot(const struct
> cgit_snapshot_format *format, return 0;
> }
>
> +static int write_sig(const struct cgit_snapshot_format *format,
> + const char *hex, const char *archive,
> + const char *filename)
> +{
> + const struct object_id *note = cgit_snapshot_get_sig(hex, format);
Do we mix declaration and code? Let's get this separated.
> + enum object_type type;
> + unsigned long size;
> + char *buf;
> [...]
But this is just nit-picking, so please add my Reviewed-by!
This will need some changes when updating to git v2.18.0. Would be nice to
have this in soon so I can rebase my commit.
[0] https://lists.zx2c4.com/pipermail/cgit/2018-March/003767.html
[1] https://lists.zx2c4.com/pipermail/cgit/2018-March/003772.html
--
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];)
putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20180607/a3339061/attachment.asc>
next reply other threads:[~2018-06-07 12:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 12:12 list [this message]
2018-06-07 12:15 ` [PATCH 1/1] snapshot: support tar signature for compressed tar list
2018-06-07 13:17 ` john
2018-06-07 15:13 ` list
2018-06-07 15:14 ` [PATCH v2 1/2] ui-snapshot: use named constants for snapshot formats list
2018-06-07 15:14 ` [PATCH v2 2/2] snapshot: support tar signature for compressed tar list
2018-06-07 15:21 ` john
2018-06-07 19:36 ` list
2018-06-07 19:38 ` [PATCH v3 1/1] " list
2018-06-27 16:34 ` Jason
2018-06-27 20:14 ` john
2018-07-02 7:10 ` list
2018-07-03 18:56 ` Jason
2018-06-08 22:11 ` [PATCH 1/1] snapshot: strip bit from struct cgit_snapshot_format list
2018-06-09 11:16 ` john
2018-06-11 6:51 ` list
2018-06-11 6:53 ` [PATCH v2 " list
2018-06-07 13:10 ` Custom snapshot prefix & Snapshot signatures john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607141251.67607d90@leda \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).