From mboxrd@z Thu Jan  1 00:00:00 1970
From: john at keeping.me.uk (John Keeping)
Date: Sun, 24 Jun 2018 12:01:24 +0100
Subject: [PATCH v3 1/6] config: add js
In-Reply-To: <152980826920.2873.1879173525795845006.stgit@mail.warmcat.com>
References: <152980795804.2873.3939128717470466784.stgit@mail.warmcat.com>
 <152980826920.2873.1879173525795845006.stgit@mail.warmcat.com>
Message-ID: <20180624110124.GI6584@john.keeping.me.uk>

On Sun, Jun 24, 2018 at 10:44:29AM +0800, Andy Green wrote:
> Just like the config allows setting css URL path,
> add a config for setting the js URL path
> 
> Setting the js path to an empty string disables
> emitting the reference to it in the head section.
> 
> Signed-off-by: Andy Green <andy at warmcat.com>

For the code changes,

Reviewed-by: John Keeping <john at keeping.me.uk>

One comment on the documentation below...

> ---
> diff --git a/cgitrc.5.txt b/cgitrc.5.txt
> index 99fc799..bdd799f 100644
> --- a/cgitrc.5.txt
> +++ b/cgitrc.5.txt
> @@ -248,6 +248,12 @@ inline-readme::
>  	individually also choose to ignore this global list, and create a
>  	repo-specific list by using 'repo.inline-readme'.
>  
> +js::
> +	Url which specifies the javascript script document to include in all cgit
> +	pages.  Default value: "/cgit.js".  Setting this to an empty string will
> +	disable the link to this file in the head section and defeat generation
> +	of any features needing functions from it.

In this version of the series, I don't think we generate anythink that
calls into JS, so can this last clause be deleted?

>  local-time::
>  	Flag which, if set to "1", makes cgit print commit and tag times in the
>  	servers timezone. Default value: "0".