From mboxrd@z Thu Jan 1 00:00:00 1970 From: john at keeping.me.uk (John Keeping) Date: Thu, 28 Jun 2018 09:32:53 +0100 Subject: [PATCH v4 16/16] md2html: change css name to not conflict with highlight In-Reply-To: <0ebaa4db-f74d-8ca0-99a2-3099e0474c26@warmcat.com> References: <152948941145.29466.10223016890282865269.stgit@mail.warmcat.com> <152948960013.29466.1632273920328107539.stgit@mail.warmcat.com> <0ebaa4db-f74d-8ca0-99a2-3099e0474c26@warmcat.com> Message-ID: <20180628083253.GU6584@john.keeping.me.uk> On Thu, Jun 28, 2018 at 05:58:42AM +0800, Andy Green wrote: > On 06/28/2018 01:37 AM, Jason A. Donenfeld wrote: > > This seems like an obvious thing to merge, but I'm actually not so > > certain I understand its necessity. md2html uses the highlight class. > > Our css uses the highlight class. You're saying this conflicts with > > something? From where? Third-party CSS? If that's the case, and if > > I'm saying blame renders wrongly on Fedora 28 for these reasons and the > patch fixes it. > > > it's a serious problem to recon with, do we then want to just > > namespace all of our classes as .cgit subclasses, or as > > .cgit-highlight, .cgit-whatever prefixes? > > I dunno what you want to do about it, but I wanted it to render > correctly on Fedora 28, which this patch is enough to do. >From the original discussion, I concluded that the problem is that both Pygments and md2html use "highlight" as a CSS class and previously we never output both of these on the same page. For some reason, Andy is getting both of these outputting their styles in ui-blame. I can't see how md2html output is ending up in that page though. John