From: john at keeping.me.uk (John Keeping)
Subject: [PATCH] Record repo.snapshot-prefix in the per-repo config
Date: Tue, 17 Jul 2018 17:57:58 +0100 [thread overview]
Message-ID: <20180717165758.GB6584@john.keeping.me.uk> (raw)
In-Reply-To: <20180717163822.GA17152@work>
On Tue, Jul 17, 2018 at 12:38:22PM -0400, Konstantin Ryabitsev wrote:
> Even if we find snapshot-prefix in the repo configuration, we are not
> writing it out into the rc- file, so setting the value does not have any
> effect.
>
> Signed-off-by: Konstantin Ryabitsev <konstantin at linuxfoundation.org>
Reviewed-by: John Keeping <john at keeping.me.uk>
To clarify why this is a problem, the repo list is cached using our
normal caching mechanism so that we don't scan for repositories on every
(uncached) request. Without this patch, only the initial request which
generates a new repo list will work and any subsequent requests using
the cached list will ignore the setting.
Of course, if caching is disabled then everything works even without
this change (guess how my test environment is set up...!).
> ---
> cgit.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/cgit.c b/cgit.c
> index e2d7891..a39d83a 100644
> --- a/cgit.c
> +++ b/cgit.c
> @@ -830,6 +830,8 @@ static void print_repo(FILE *f, struct cgit_repo *repo)
> fprintf(f, "repo.snapshots=%s\n", tmp ? tmp : "");
> free(tmp);
> }
> + if (repo->snapshot_prefix)
> + fprintf(f, "repo.snapshot-prefix=%s\n", repo->snapshot_prefix);
> if (repo->max_stats != ctx.cfg.max_stats)
> fprintf(f, "repo.max-stats=%s\n",
> cgit_find_stats_periodname(repo->max_stats));
> --
> 2.17.1
next prev parent reply other threads:[~2018-07-17 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 16:24 repo.snapshot-prefix not working konstantin
2018-07-17 16:38 ` [PATCH] Record repo.snapshot-prefix in the per-repo config konstantin
2018-07-17 16:57 ` john [this message]
2018-07-17 17:12 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717165758.GB6584@john.keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).