From mboxrd@z Thu Jan 1 00:00:00 1970 From: actionmystique at gmail.com (jean-christophe manciot) Date: Sat, 25 Aug 2018 09:41:44 +0200 Subject: The logo of the about page is never shown although it is displayed on all other pages Message-ID: I use *v1.2.1* with the patch regarding the table of contents . I have the following setup: /etc/cgitrc: logo=/cgit-css/cgit.png Each repo has its own cgitrc, for instance: logo=https://git.sdxlive.com/PPA/plain/logo.png logo-link=https://help.ubuntu.com/lts/serverguide/index.html The logo is displayed correctly on all pages (summary, refs, log, ...) except on the about page where I get: [image: about-logo.png] I suspect that something in the README.md file bothers cgit, so here is the first lines: GPLv3
**DR** by **Jean-Christophe Manciot** is licensed under a **GPLv3 License**. ## Table of Contents [TOC] Any suggestion? -- Jean-Christophe -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: about-logo.png Type: image/png Size: 2662 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: john at keeping.me.uk (John Keeping) Date: Sat, 25 Aug 2018 10:50:53 +0100 Subject: The logo of the about page is never shown although it is displayed on all other pages In-Reply-To: References: Message-ID: <20180825095053.GB824@john.keeping.me.uk> On Sat, Aug 25, 2018 at 09:41:44AM +0200, jean-christophe manciot wrote: > I use *v1.2.1* with the patch regarding the table of contents > > . > I have the following setup: > /etc/cgitrc: > logo=/cgit-css/cgit.png > > Each repo has its own cgitrc, for instance: > logo=https://git.sdxlive.com/PPA/plain/logo.png > logo-link=https://help.ubuntu.com/lts/serverguide/index.html > > The logo is displayed correctly on all pages (summary, refs, log, ...) > except on the about page where I get: Can you share a public URL demonstrating the problem? The code for outputting the page header (including the logo) is shared for all pages so I can't see why it would output a broken link just on the about page. From mboxrd@z Thu Jan 1 00:00:00 1970 From: actionmystique at gmail.com (jean-christophe manciot) Date: Sat, 25 Aug 2018 16:24:15 +0200 Subject: The logo of the about page is never shown although it is displayed on all other pages In-Reply-To: <20180825095053.GB824@john.keeping.me.uk> References: <20180825095053.GB824@john.keeping.me.uk> Message-ID: Something strange happened. I played with some settings to find a workaround, and the issue vanished suddenly: I was careful about the a 'cache-about-ttl=1' parameter to make sure the cache was not involved in this. I refreshed the about page several times during a few mins, but the issue was still there. I added a 'homepage=https://git.sdxlive.com//about' in the cgitrc file of all the repos and after some time (more than 1 mn), the issue was gone. I removed those settings and the issue did not resurface. All these tests were done with chrome 68.0.3440.106. If you want to check it out, the website is live at *https://git.sdxlive.com *. On Sat, Aug 25, 2018 at 11:50 AM John Keeping wrote: > On Sat, Aug 25, 2018 at 09:41:44AM +0200, jean-christophe manciot wrote: > > I use *v1.2.1* with the patch regarding the table of contents > > < > https://git.zx2c4.com/cgit/diff/filters/html-converters/md2html?h=ch/anchorlinks&id=42e70dcbe84e128ba23a25918e3d5d9aac656dc6 > > > > . > > I have the following setup: > > /etc/cgitrc: > > logo=/cgit-css/cgit.png > > > > Each repo has its own cgitrc, for instance: > > logo=https://git.sdxlive.com/PPA/plain/logo.png > > logo-link=https://help.ubuntu.com/lts/serverguide/index.html > > > > The logo is displayed correctly on all pages (summary, refs, log, ...) > > except on the about page where I get: > > Can you share a public URL demonstrating the problem? > > The code for outputting the page header (including the logo) is shared > for all pages so I can't see why it would output a broken link just on > the about page. > -- Jean-Christophe -------------- next part -------------- An HTML attachment was scrubbed... URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: john at keeping.me.uk (John Keeping) Date: Sat, 25 Aug 2018 18:39:49 +0100 Subject: The logo of the about page is never shown although it is displayed on all other pages In-Reply-To: References: <20180825095053.GB824@john.keeping.me.uk> Message-ID: <20180825173949.GC824@john.keeping.me.uk> On Sat, Aug 25, 2018 at 04:24:15PM +0200, jean-christophe manciot wrote: > Something strange happened. > I played with some settings to find a workaround, and the issue vanished > suddenly: > I was careful about the a 'cache-about-ttl=1' parameter to make sure the > cache was not involved in this. > I refreshed the about page several times during a few mins, but the issue > was still there. > I added a 'homepage=https://git.sdxlive.com//about' in the > cgitrc file of all the repos and after some time (more than 1 mn), the > issue was gone. This sounds like a cache issue somewhere, whether that's CGit or your browser or somewhere in between. If the cache TTL was originally longer, then that will have been included in the HTTP Expires header on earlier results so it's possible that the older response was still cached based on the previous TTL. > On Sat, Aug 25, 2018 at 11:50 AM John Keeping wrote: > > > On Sat, Aug 25, 2018 at 09:41:44AM +0200, jean-christophe manciot wrote: > > > I use *v1.2.1* with the patch regarding the table of contents > > > < > > https://git.zx2c4.com/cgit/diff/filters/html-converters/md2html?h=ch/anchorlinks&id=42e70dcbe84e128ba23a25918e3d5d9aac656dc6 > > > > > > . > > > I have the following setup: > > > /etc/cgitrc: > > > logo=/cgit-css/cgit.png > > > > > > Each repo has its own cgitrc, for instance: > > > logo=https://git.sdxlive.com/PPA/plain/logo.png > > > logo-link=https://help.ubuntu.com/lts/serverguide/index.html > > > > > > The logo is displayed correctly on all pages (summary, refs, log, ...) > > > except on the about page where I get: > > > > Can you share a public URL demonstrating the problem? > > > > The code for outputting the page header (including the logo) is shared > > for all pages so I can't see why it would output a broken link just on > > the about page. > > > > > -- > Jean-Christophe