The logo of the about page is never shown although it is displayed on all other pages

The logo of the about page is never shown although it is displayed on all other pages

[actionmystique]

I use *v1.2.1* with the patch regarding the table of contents
<https://git.zx2c4.com/cgit/diff/filters/html-converters/md2html?h=ch/anchorlinks&id=42e70dcbe84e128ba23a25918e3d5d9aac656dc6>
 .
I have the following setup:
/etc/cgitrc:
logo=/cgit-css/cgit.png

Each repo has its own cgitrc, for instance:
logo=https://git.sdxlive.com/PPA/plain/logo.png
logo-link=https://help.ubuntu.com/lts/serverguide/index.html

The logo is displayed correctly on all pages (summary, refs, log, ...)
except on the about page where I get:
[image: about-logo.png]
I suspect that something in the README.md file bothers cgit, so here is the
first lines:
<a rel="license" href="https://www.gnu.org/licenses/gpl-3.0.md"><img
alt="GPLv3" src="https://www.gnu.org/graphics/gplv3-127x51.png" /></a><br
/><span xmlns:dct="http://purl.org/dc/terms/"
property="dct:title">**DR**</span> by <a href="
https://plus.google.com/u/0/+jeanchristopheManciot-IT/posts">**Jean-Christophe
Manciot**</a> is licensed under a <a rel="license" href="
https://www.gnu.org/licenses/gpl-3.0.md">**GPLv3 License**</a>.

## Table of Contents

[TOC]

Any suggestion?
-- 
Jean-Christophe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20180825/d75735b8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: about-logo.png
Type: image/png
Size: 2662 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20180825/d75735b8/attachment.png>

The logo of the about page is never shown although it is displayed on all other pages

[john]

On Sat, Aug 25, 2018 at 09:41:44AM +0200, jean-christophe manciot wrote:
> I use *v1.2.1* with the patch regarding the table of contents
> <https://git.zx2c4.com/cgit/diff/filters/html-converters/md2html?h=ch/anchorlinks&id=42e70dcbe84e128ba23a25918e3d5d9aac656dc6>
>  .
> I have the following setup:
> /etc/cgitrc:
> logo=/cgit-css/cgit.png
> 
> Each repo has its own cgitrc, for instance:
> logo=https://git.sdxlive.com/PPA/plain/logo.png
> logo-link=https://help.ubuntu.com/lts/serverguide/index.html
> 
> The logo is displayed correctly on all pages (summary, refs, log, ...)
> except on the about page where I get:

Can you share a public URL demonstrating the problem?

The code for outputting the page header (including the logo) is shared
for all pages so I can't see why it would output a broken link just on
the about page.

The logo of the about page is never shown although it is displayed on all other pages

[actionmystique]

Something strange happened.
I played with some settings to find a workaround, and the issue vanished
suddenly:
I was careful about the a 'cache-about-ttl=1' parameter to make sure the
cache was not involved in this.
I refreshed the about page several times during a few mins, but the issue
was still there.
I added a 'homepage=https://git.sdxlive.com/<repository_name>/about' in the
cgitrc file of all the repos  and after some time (more than 1 mn), the
issue was gone.
I removed those settings and the issue did not resurface.
All these tests were done with chrome 68.0.3440.106.
If you want to check it out, the website is live at *https://git.sdxlive.com
<https://git.sdxlive.com>*.


On Sat, Aug 25, 2018 at 11:50 AM John Keeping <john at keeping.me.uk> wrote:

> On Sat, Aug 25, 2018 at 09:41:44AM +0200, jean-christophe manciot wrote:
> > I use *v1.2.1* with the patch regarding the table of contents
> > <
> https://git.zx2c4.com/cgit/diff/filters/html-converters/md2html?h=ch/anchorlinks&id=42e70dcbe84e128ba23a25918e3d5d9aac656dc6
> >
> >  .
> > I have the following setup:
> > /etc/cgitrc:
> > logo=/cgit-css/cgit.png
> >
> > Each repo has its own cgitrc, for instance:
> > logo=https://git.sdxlive.com/PPA/plain/logo.png
> > logo-link=https://help.ubuntu.com/lts/serverguide/index.html
> >
> > The logo is displayed correctly on all pages (summary, refs, log, ...)
> > except on the about page where I get:
>
> Can you share a public URL demonstrating the problem?
>
> The code for outputting the page header (including the logo) is shared
> for all pages so I can't see why it would output a broken link just on
> the about page.
>


-- 
Jean-Christophe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20180825/18094b34/attachment.html>

The logo of the about page is never shown although it is displayed on all other pages

[john]

On Sat, Aug 25, 2018 at 04:24:15PM +0200, jean-christophe manciot wrote:
> Something strange happened.
> I played with some settings to find a workaround, and the issue vanished
> suddenly:
> I was careful about the a 'cache-about-ttl=1' parameter to make sure the
> cache was not involved in this.
> I refreshed the about page several times during a few mins, but the issue
> was still there.
> I added a 'homepage=https://git.sdxlive.com/<repository_name>/about' in the
> cgitrc file of all the repos  and after some time (more than 1 mn), the
> issue was gone.

This sounds like a cache issue somewhere, whether that's CGit or your
browser or somewhere in between.  If the cache TTL was originally
longer, then that will have been included in the HTTP Expires header on
earlier results so it's possible that the older response was still
cached based on the previous TTL.

> On Sat, Aug 25, 2018 at 11:50 AM John Keeping <john at keeping.me.uk> wrote:
> 
> > On Sat, Aug 25, 2018 at 09:41:44AM +0200, jean-christophe manciot wrote:
> > > I use *v1.2.1* with the patch regarding the table of contents
> > > <
> > https://git.zx2c4.com/cgit/diff/filters/html-converters/md2html?h=ch/anchorlinks&id=42e70dcbe84e128ba23a25918e3d5d9aac656dc6
> > >
> > >  .
> > > I have the following setup:
> > > /etc/cgitrc:
> > > logo=/cgit-css/cgit.png
> > >
> > > Each repo has its own cgitrc, for instance:
> > > logo=https://git.sdxlive.com/PPA/plain/logo.png
> > > logo-link=https://help.ubuntu.com/lts/serverguide/index.html
> > >
> > > The logo is displayed correctly on all pages (summary, refs, log, ...)
> > > except on the about page where I get:
> >
> > Can you share a public URL demonstrating the problem?
> >
> > The code for outputting the page header (including the logo) is shared
> > for all pages so I can't see why it would output a broken link just on
> > the about page.
> >
> 
> 
> -- 
> Jean-Christophe