From: dlcampbell at gmx.com (Daniel Campbell)
Subject: [BUG] cgit W3 validator fail
Date: Sat, 20 Oct 2018 02:12:33 -0700 [thread overview]
Message-ID: <20181020091233.GC4977@clocktown> (raw)
In-Reply-To: <CA+KR5Pw-AOX00h+uoa5Xzk9k65pq-JXWWCJZEY5HQbXG6iK1fw@mail.gmail.com>
On Thu, Oct 18, 2018 at 10:27:29AM +0300, Anast Gramm wrote:
> Hello. I recently got into some html "programming" and found out
> about the w3 validator service https://validator.w3.org/
>
> Upon running it on a cgit site I own an error occurred:
>
> > The summary attribute on the table element is obsolete.
> > Consider describing the structure of the table in a caption element
> > or in a figure element containing the table; or, simplify the
> > structure of the table so that no description is needed.
>
> A quick grep through the code showed some lines containing the obsolete
> html.
>
> Should the summary attribute be moved into a caption or
> should it be removed all together?
The summary attribute is deprecated in HTML 5. Earlier versions may
still support it. I checked the source on various pages in my cgit
installation and they seem to contain generic information like
"repository info", "repository list", and so on. These same tables
already have CSS classes applied, though one could choose to style the
two differently with CSS(3) rules like:
table[summary="repository info"] {
color: #f00;
}
I wrote two patches to fix this: the first patch simply removes the
"summary='...'" parts, and the second adds classes (where needed) so
that style writers that used the above method to style can still target
the same elements, retaining specificity and shortening their selectors.
I have attached the patches to this e-mail for review.
~Daniel
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ui-remove-summary-attribute-from-table-elements.patch
Type: text/x-diff
Size: 4444 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20181020/6ac275f6/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ui-add-classes-to-supplement-missing-summary-info.patch
Type: text/x-diff
Size: 2532 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20181020/6ac275f6/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20181020/6ac275f6/attachment.asc>
prev parent reply other threads:[~2018-10-20 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 7:27 anastasis.gramm2
2018-10-20 9:12 ` dlcampbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181020091233.GC4977@clocktown \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).