Subject: CGIT_REPO_* environment variables in auth filter?
Date: Sun, 21 Oct 2018 17:20:03 +0200 [thread overview]
Message-ID: <20181021152003.GA24245@STATENS_laptop> (raw)
In-Reply-To: <20181020160052.GA9358@STATENS_laptop>
I started reading the source myself, and found that
cgit_prepare_repo_env is called after all authentication
filters.
The diff below shows a possible fix. It does however only
apply for authenticate-cookie and body, and not
authenticate-post (apparently due to the repo only being
loaded in the former two cases).
diff --git a/cgit.c b/cgit.c
index 6301b87..7a4978e 100644
--- a/cgit.c
+++ b/cgit.c
@@ -1081,6 +1081,9 @@ int cmd_main(int argc, const char **argv)
cgit_parse_url(ctx.qry.url);
}
+ if (ctx.repo)
+ cgit_prepare_repo_env(ctx.repo);
+
/* Before we go any further, we set ctx.env.authenticated by checking to see
* if the supplied cookie is valid. All cookies are valid if there is no
* auth_filter. If there is an auth_filter, the filter decides. */
On Sat, Oct 20, 2018 at 06:00:52PM +0200, Hugo H?rnquist wrote:
> Hi!
>
> The manual (cgitrc(5)) states that "All filters are handed
> the following environment variable:" and lists the different
> CGIT_REPO_* variables. I'm trying to access them from an
> auth filter written in lua (a slight modification of the
> included simple-authentication.lua) but they are all unset.
>
> I have tested running cgit through nginx, lighttpd and
> directly. And none of them worked. Is there something I'm
> missing? Or is this by design and the documentation is
> wrong?
>
> The variables are however available in a shell-script
> source-filter.
>
> Thanks in advance for the help.
>
> --
> hugo
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/cgit
--
hugo
prev parent reply other threads:[~2018-10-21 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 16:00
2018-10-21 15:20 ` [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181021152003.GA24245@STATENS_laptop \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).