List for cgit developers and users
 help / color / Atom feed
* [PATCH 1/1] ui-shared: add parentheses to suppress compiler warning
@ 2019-01-02 16:27 list
  0 siblings, 0 replies; only message in thread
From: list @ 2019-01-02 16:27 UTC (permalink / raw)


From: Christian Hesse <mail at eworm.de>

warning: suggest parentheses around assignment used as
truth value [-Wparentheses]

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 ui-shared.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui-shared.c b/ui-shared.c
index 00d9ed1..6d1238d 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -1198,7 +1198,7 @@ void cgit_set_title_from_path(const char *path)
 	if (!path)
 		return;
 
-	for (last_slash = path + strlen(path); slash = memrchr(path, '/', last_slash - path); last_slash = slash) {
+	for (last_slash = path + strlen(path); (slash = memrchr(path, '/', last_slash - path)); last_slash = slash) {
 		strbuf_add(&sb, slash + 1, last_slash - slash - 1);
 		strbuf_addstr(&sb, " \xc2\xab ");
 	}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-02 16:27 [PATCH 1/1] ui-shared: add parentheses to suppress compiler warning list

List for cgit developers and users

Archives are clonable: git clone --mirror http://inbox.vuxu.org/cgit

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.cgit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git