List for cgit developers and users
 help / color / mirror / Atom feed
From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/2] ui-ssdiff: ban strncat()
Date: Sun, 10 Feb 2019 14:08:18 +0100	[thread overview]
Message-ID: <20190210140818.31f5459c@leda> (raw)
In-Reply-To: <CAHmME9p1vsxeOuwUASCexEM=z9q5KwrWNrQHHEXzHy1bbD29Lw@mail.gmail.com>

"Jason A. Donenfeld" <Jason at zx2c4.com> on Sat, 2019/02/09 12:31:
> You sure those statements are the same? Snprintf doesn't append like
> strncat. Wouldn't strlcat be the more apt replacement?

We have an unconditional

result[0] = '\0';

that mad be think it is safe. But we are inside a loop, so probably not... :-p
Let me have another look.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20190210/73c9974b/attachment.asc>


  reply	other threads:[~2019-02-10 13:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 10:21 [PATCH 1/1] RFC: git: update to v2.21.0-rc0 list
2019-02-07 10:57 ` john
2019-02-08 21:48   ` [PATCH 1/2] ui-ssdiff: ban strncat() list
2019-02-09 11:31     ` Jason
2019-02-10 13:08       ` list [this message]
2019-02-12 20:07       ` list
2019-02-12 20:55     ` [PATCH v2 1/1] " list
2019-02-13  8:29       ` e
2019-02-14 22:41         ` list

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190210140818.31f5459c@leda \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).