From mboxrd@z Thu Jan 1 00:00:00 1970 From: e at 80x24.org (Eric Wong) Date: Wed, 13 Feb 2019 08:29:02 +0000 Subject: [PATCH v2 1/1] ui-ssdiff: ban strncat() In-Reply-To: <20190212205532.27161-1-list@eworm.de> References: <20190208214812.26937-1-list@eworm.de> <20190212205532.27161-1-list@eworm.de> Message-ID: <20190213082901.meyuac432qvellvf@dcvr> Christian Hesse wrote: > From: Christian Hesse > > Git version v2.21.0 marks strncat() as banned (commit > ace5707a803eda0f1dde3d776dc3729d3bc7759a), so replace it. Btw, I posted a similar-in-spirit patch to replace strncat in ui-ssdiff.c back in January: <20190102073710.580-1-e at 80x24.org> It uses strbuf and is close to code which already exists in git.git, so it doesn't make calls to strlen() repeatedly. (I'm also responsible for strncat banning in git.git :)