List for cgit developers and users
 help / color / mirror / Atom feed
From: list at (Christian Hesse)
Subject: [PATCH v2 1/1] ui-ssdiff: ban strncat()
Date: Thu, 14 Feb 2019 23:41:19 +0100	[thread overview]
Message-ID: <20190214234007.5b1d9714@leda> (raw)
In-Reply-To: <20190213082901.meyuac432qvellvf@dcvr>

Eric Wong <e at> on Wed, 2019/02/13 08:29:
> Christian Hesse <list at> wrote:
> > From: Christian Hesse <mail at>
> > 
> > Git version v2.21.0 marks strncat() as banned (commit
> > ace5707a803eda0f1dde3d776dc3729d3bc7759a), so replace it.  
> Btw, I posted a similar-in-spirit patch to replace strncat
> in ui-ssdiff.c back in January: <20190102073710.580-1-e at>
> It uses strbuf and is close to code which already exists in
> git.git, so it doesn't make calls to strlen() repeatedly.
> (I'm also responsible for strncat banning in git.git :)

Ah, nice... I saw this but forgot about it. :-p

Jason, you are free to decide. ;)
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <>

      reply	other threads:[~2019-02-14 22:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 10:21 [PATCH 1/1] RFC: git: update to v2.21.0-rc0 list
2019-02-07 10:57 ` john
2019-02-08 21:48   ` [PATCH 1/2] ui-ssdiff: ban strncat() list
2019-02-09 11:31     ` Jason
2019-02-10 13:08       ` list
2019-02-12 20:07       ` list
2019-02-12 20:55     ` [PATCH v2 1/1] " list
2019-02-13  8:29       ` e
2019-02-14 22:41         ` list [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190214234007.5b1d9714@leda \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).