List for cgit developers and users
 help / color / mirror / Atom feed
From: aklhfex at gmail.com (Chris Mayo)
Subject: [PATCH] html: fully escape links on index page descriptions
Date: Mon, 18 Feb 2019 20:14:17 +0000	[thread overview]
Message-ID: <20190218201417.31193-1-aklhfex@gmail.com> (raw)

A space in repo.url was being converted to %20 in the link on repository
name but not in the link on repository description.

Signed-off-by: Chris Mayo <aklhfex at gmail.com>
---
 html.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html.c b/html.c
index 7f81965..f731c72 100644
--- a/html.c
+++ b/html.c
@@ -288,7 +288,7 @@ void html_intoption(int value, const char *text, int selected_value)
 void html_link_open(const char *url, const char *title, const char *class)
 {
 	html("<a href='");
-	html_attr(url);
+	html_url_path(url);
 	if (title) {
 		html("' title='");
 		html_attr(title);
-- 
2.20.1



                 reply	other threads:[~2019-02-18 20:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218201417.31193-1-aklhfex@gmail.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).