List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH 0/5] SVG diffstat graphs and HTML5
@ 2019-02-18 20:46 aklhfex
  2019-02-18 20:46 ` [PATCH 1/5] ui-diff: use SVG for diffstat graphs aklhfex
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: aklhfex @ 2019-02-18 20:46 UTC (permalink / raw)


diffstat graphs were not displaying correctly for me because their use of
inline style was being blocked by my content security policy. So I rewrote
them in SVG, which also saves a nested table and a padding element.

As part of checking this I ran the W3C Markup Validator, which reported
several HTML errors and warnings. Hence the rest of the patches here which
fix a number of errors and warnings, but not all e.g. ssdiff still causes
errors for reusing id's.

For the deprecated table summary attribute, not sure what the intent of this
was, I replaced with aria-label, if it was for accessibility.
Maybe "data-summary" instead?

Chris Mayo (5):
  ui-diff: use SVG for diffstat graphs
  Replace table summary attribute with aria-label
  Replace self-closing syntax on non-void elements
  ui-log,ui-refs: ensure there are cells for each column
  ui-shared: add encoding declaration

 cgit.css              | 16 +++++-----------
 tests/t0105-commit.sh |  2 +-
 ui-commit.c           |  2 +-
 ui-diff.c             | 26 +++++++++++++-------------
 ui-log.c              |  6 +++++-
 ui-refs.c             |  2 +-
 ui-repolist.c         |  2 +-
 ui-shared.c           |  1 +
 ui-stats.c            |  4 ++--
 ui-summary.c          |  2 +-
 ui-tree.c             |  8 ++++----
 11 files changed, 35 insertions(+), 36 deletions(-)

-- 
2.20.1



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-02-18 21:15 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 20:46 [PATCH 0/5] SVG diffstat graphs and HTML5 aklhfex
2019-02-18 20:46 ` [PATCH 1/5] ui-diff: use SVG for diffstat graphs aklhfex
2019-02-18 20:46 ` [PATCH 2/5] Replace table summary attribute with aria-label aklhfex
2019-02-18 20:46 ` [PATCH 3/5] Replace self-closing syntax on non-void elements aklhfex
2019-02-18 20:46 ` [PATCH 4/5] ui-log,ui-refs: ensure there are cells for each column aklhfex
     [not found]   ` <CAGFiPxeyoWYT44SUOo-isKeErvYu-c4J78HtWnwse3ueKQV0fA@mail.gmail.com>
     [not found]     ` <CAGFiPxfmGgy0OVCnxNs6aY5RG9XNQGohOerv2Xu0GhV2KHpG5g@mail.gmail.com>
2019-02-18 21:15       ` [PATCH 4/5] ui-log, ui-refs: " 1melissadenee
2019-02-18 20:46 ` [PATCH 5/5] ui-shared: add encoding declaration aklhfex

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).