From: aklhfex at gmail.com (Chris Mayo)
Subject: [PATCH] ui-diff,ui-tag: don't use htmlf with non-formatted strings
Date: Thu, 21 Feb 2019 19:57:23 +0000 [thread overview]
Message-ID: <20190221195723.15907-1-aklhfex@gmail.com> (raw)
Signed-off-by: Chris Mayo <aklhfex at gmail.com>
---
ui-diff.c | 2 +-
ui-tag.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ui-diff.c b/ui-diff.c
index 70dcc91..c60aefd 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -82,7 +82,7 @@ static void print_fileinfo(struct fileinfo *info)
}
html("<tr>");
- htmlf("<td class='mode'>");
+ html("<td class='mode'>");
if (is_null_oid(info->new_oid)) {
cgit_print_filemode(info->old_mode);
} else {
diff --git a/ui-tag.c b/ui-tag.c
index f530224..846d5b1 100644
--- a/ui-tag.c
+++ b/ui-tag.c
@@ -71,7 +71,7 @@ void cgit_print_tag(char *revname)
}
cgit_print_layout_start();
html("<table class='commit-info'>\n");
- htmlf("<tr><td>tag name</td><td>");
+ html("<tr><td>tag name</td><td>");
html_txt(revname);
htmlf(" (%s)</td></tr>\n", oid_to_hex(&oid));
if (info->tagger_date > 0) {
@@ -103,7 +103,7 @@ void cgit_print_tag(char *revname)
} else {
cgit_print_layout_start();
html("<table class='commit-info'>\n");
- htmlf("<tr><td>tag name</td><td>");
+ html("<tr><td>tag name</td><td>");
html_txt(revname);
html("</td></tr>\n");
html("<tr><td>tagged object</td><td class='sha1'>");
--
2.20.1
next reply other threads:[~2019-02-21 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 19:57 aklhfex [this message]
2019-02-22 23:09 ` [PATCH] ui-diff, ui-tag: " Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221195723.15907-1-aklhfex@gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).