* [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors
@ 2019-03-15 20:17 aklhfex
2019-04-03 1:24 ` e
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: aklhfex @ 2019-03-15 20:17 UTC (permalink / raw)
The title attribute was being set to the same value as the anchor
element text.
Signed-off-by: Chris Mayo <aklhfex at gmail.com>
---
ui-repolist.c | 2 +-
ui-shared.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui-repolist.c b/ui-repolist.c
index 41424c0..80c85d3 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -321,7 +321,7 @@ void cgit_print_repolist(void)
}
htmlf("<tr><td class='%s'>",
!sorted && section ? "sublevel-repo" : "toplevel-repo");
- cgit_summary_link(ctx.repo->name, ctx.repo->name, NULL, NULL);
+ cgit_summary_link(ctx.repo->name, NULL, NULL, NULL);
html("</td><td>");
repourl = cgit_repourl(ctx.repo->url);
html_link_open(repourl, NULL, NULL);
diff --git a/ui-shared.c b/ui-shared.c
index d27a5fd..13d54af 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -992,7 +992,7 @@ static void print_header(void)
if (ctx.repo) {
cgit_index_link("index", NULL, NULL, NULL, NULL, 0, 1);
html(" : ");
- cgit_summary_link(ctx.repo->name, ctx.repo->name, NULL, NULL);
+ cgit_summary_link(ctx.repo->name, NULL, NULL, NULL);
if (ctx.env.authenticated) {
html("</td><td class='form'>");
html("<form method='get'>\n");
--
2.21.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors
2019-03-15 20:17 [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors aklhfex
@ 2019-04-03 1:24 ` e
2019-04-16 16:47 ` petr.vorel
2022-12-19 14:31 ` Jason A. Donenfeld
2 siblings, 0 replies; 4+ messages in thread
From: e @ 2019-04-03 1:24 UTC (permalink / raw)
Chris Mayo <aklhfex at gmail.com> wrote:
> The title attribute was being set to the same value as the anchor
> element text.
>
> Signed-off-by: Chris Mayo <aklhfex at gmail.com>
I am not an HTML expert; but it looks like a reasonable change to
avoid the redundant tooltip.
Acked-by: Eric Wong <e at 80x24.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors
2019-03-15 20:17 [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors aklhfex
2019-04-03 1:24 ` e
@ 2019-04-16 16:47 ` petr.vorel
2022-12-19 14:31 ` Jason A. Donenfeld
2 siblings, 0 replies; 4+ messages in thread
From: petr.vorel @ 2019-04-16 16:47 UTC (permalink / raw)
Hi,
> The title attribute was being set to the same value as the anchor
> element text.
> Signed-off-by: Chris Mayo <aklhfex at gmail.com>
Reviewed-by: Petr Vorel <petr.vorel at gmail.com>
Good idea.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors
2019-03-15 20:17 [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors aklhfex
2019-04-03 1:24 ` e
2019-04-16 16:47 ` petr.vorel
@ 2022-12-19 14:31 ` Jason A. Donenfeld
2 siblings, 0 replies; 4+ messages in thread
From: Jason A. Donenfeld @ 2022-12-19 14:31 UTC (permalink / raw)
To: Chris Mayo; +Cc: cgit
Applied, thanks.
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-19 14:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 20:17 [PATCH] ui-repolist, ui-shared: remove redundant title on repo anchors aklhfex
2019-04-03 1:24 ` e
2019-04-16 16:47 ` petr.vorel
2022-12-19 14:31 ` Jason A. Donenfeld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).