From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH] ui-shared: restrict to 15 levels
Date: Mon, 20 May 2019 21:55:06 +0200 [thread overview]
Message-ID: <20190520195506.16860-1-Jason@zx2c4.com> (raw)
In-Reply-To: <Leu8zHu--3-1@tuta.io>
Perhaps a more ideal version of this would be to not print breadcrumbs
at all for paths that don't exist in the given repo at the given oid.
Signed-off-by: Jason A. Donenfeld <Jason at zx2c4.com>
Reported-by: Fydor Wire Snark <wsnark at tuta.io>
---
I've committed this, and it works. But if anyone would like to give the
implementation a stab, I think a better approach might be simply
skipping printing of breadcrumbs in cases where the path doesn't exist
in the repo. This way we're not limited to some reasonable constant such
as 15.
ui-shared.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ui-shared.c b/ui-shared.c
index d27a5fd..d2358f2 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -945,12 +945,13 @@ static void cgit_print_path_crumbs(char *path)
{
char *old_path = ctx.qry.path;
char *p = path, *q, *end = path + strlen(path);
+ int levels = 0;
ctx.qry.path = NULL;
cgit_self_link("root", NULL, NULL);
ctx.qry.path = p = path;
while (p < end) {
- if (!(q = strchr(p, '/')))
+ if (!(q = strchr(p, '/')) || levels > 15)
q = end;
*q = '\0';
html_txt("/");
@@ -958,6 +959,7 @@ static void cgit_print_path_crumbs(char *path)
if (q < end)
*q = '/';
p = q + 1;
+ ++levels;
}
ctx.qry.path = old_path;
}
--
2.21.0
next parent reply other threads:[~2019-05-20 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Leu8zHu--3-1@tuta.io>
2019-05-20 19:55 ` Jason [this message]
2019-05-20 22:05 ` john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520195506.16860-1-Jason@zx2c4.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).