List for cgit developers and users
 help / color / mirror / Atom feed
From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/2] ui-snapshot: add support for zstd compression
Date: Wed, 26 Feb 2020 23:38:11 +0100	[thread overview]
Message-ID: <20200226233811.0ea5d161@leda> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2002261715550.3793@Zeta>

Unit 193 <unit193 at ubuntu.com> on Wed, 2020/02/26 17:21:
> > Wow, thanks for doing this. I had just been discussing this with
> > Unit193, who submitted a similar but not as complete patch a few days
> > ago to me on IRC.  
> 
> Indeed!  Thanks for looking into this!

I just implemented this after the lzip patch was merged... Did not even know
you discussed this. :-p

> > We had been discussing which compression level to pass to zstd or to
> > leave it as default. I think Unit193 had some thoughts on that, so
> > CC'ing him in case he wants to jump in.  
> 
> Yes.  My initial version did bump the compression level as well, but in the
> end I decided against that in order to give the user the option to control
> that via ZSTD_CLEVEL.

Good idea... So we could go with `xz -T0` to enable multi-threading (as this
can not be controlled via environment variable).
Then we document in man page how to influence compression level via
environment variable.

We have to set the environment variable from web server, no?

Do we also want to document GZIP, XZ_DEFAULTS & friends?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Best regards             my address:    */=0;b=c[a++];)
putchar(b-1/(/*    Chris            cc -ox -xc - && ./x    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20200226/dbd549dd/attachment.asc>


  parent reply	other threads:[~2020-02-26 22:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  8:21 list
2020-02-26  8:21 ` [PATCH 2/2] tests: add tests for xz compressed snapshots list
2020-02-26  9:19   ` Jason
2020-02-26  9:16 ` [PATCH 1/2] ui-snapshot: add support for zstd compression Jason
2020-02-26 10:18   ` list
2020-02-26 10:28     ` list
     [not found]   ` <alpine.DEB.2.22.394.2002261715550.3793@Zeta>
2020-02-26 22:38     ` list [this message]
2020-02-26 21:24 ` [PATCH v2 " list

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226233811.0ea5d161@leda \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).