From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 1532 invoked from network); 29 Aug 2020 11:04:14 -0000 Received: from krantz.zx2c4.com (192.95.5.69) by inbox.vuxu.org with ESMTPUTF8; 29 Aug 2020 11:04:14 -0000 Received: by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 20121ccc; Sat, 29 Aug 2020 10:36:33 +0000 (UTC) Return-Path: Received: from mail.thenautilus.net (mail.thenautilus.net [5.79.87.27]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 3d22d6cd (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sat, 29 Aug 2020 10:36:30 +0000 (UTC) Received: (qmail 4585 invoked from network); 29 Aug 2020 11:03:52 -0000 Received: from unknown (HELO nautilus) (dakkar@::ffff:81.2.107.215) by 0 with ESMTPA; 29 Aug 2020 11:03:52 -0000 Date: Sat, 29 Aug 2020 12:03:49 +0100 From: Gianni Ceccarelli To: cgit@lists.zx2c4.com Subject: Possible case-sensitivity issue in module-link Message-ID: <20200829120349.164c484c@nautilus> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" Hello! I use cgit on my own site https://www.thenautilus.net/cgit/ Some of my repositories contain submodules, for example https://www.thenautilus.net/cgit/Sietima/tree/docs/presentation/ https://www.thenautilus.net/cgit/thermostat/tree/ https://www.thenautilus.net/cgit/thermostat/tree/sensor/ https://www.thenautilus.net/cgit/lego-piano/tree/ https://www.thenautilus.net/cgit/lego-piano/tree/3d-print All those submodules are listed in the repo's config file, for example ``thermostat/config`` contains:: [cgit "module-link"] esp8266-oled-ssd1306 = https://github.com/ThingPulse/esp8266-oled-ssd1306/tree/%s DHTesp = https://github.com/beegee-tokyo/DHTesp/tree/%s bt-server = https://www.thenautilus.net/cgit/gobbledegook/tree/?id=%s and ``lego-piano/config`` contains:: [cgit "module-link"] RingBuffer = https://github.com/Locoduino/RingBuffer/tree/%s ESP8266Audio = https://github.com/earlephilhower/ESP8266Audio/tree/%s [cgit "module-link.3d-print/LEGO"] scad = https://github.com/cfinke/LEGO.scad/tree/%s You may have noticed that only *some* submodules show up as links in the CGit output: - ``esp8266-oled-ssd1306``, ``bt-server``, ``LEGO.scad`` work - ``DHTesp``, ``RingBuffer``, ``ESP8266Audio`` don't My suspicion is that the case of the characters after the last ``.`` is involved: if they're all lowercase, the link works, if some are uppercase, it doesn't. Running ``git config -l`` in the ``lego-piano`` repository directory, for example, I get:: cgit.module-link.ringbuffer=https://github.com/Locoduino/RingBuffer/tree/%s cgit.module-link.esp8266audio=https://github.com/earlephilhower/ESP8266Audio/tree/%s cgit.module-link.3d-print/LEGO.scad=https://github.com/cfinke/LEGO.scad/tree/%s notice that ``ringbuffer`` and ``esp8266audio`` got lowercased, but ``LEGO`` didn't. If the configuration is parsed like this, and the submodule's path is then matched case-sensitively, the result would be what I observe. Can anyone confirm? I've been reading the source of CGit plus the bits of Git that are linked in, but I haven't found code that would produce the behaviour I see. Thanks in advance. -- Dakkar - GPG public key fingerprint = A071 E618 DD2C 5901 9574 6FE2 40EA 9883 7519 3F88 key id = 0x75193F88