From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI autolearn=ham autolearn_force=no
	version=3.4.4
Received: (qmail 15637 invoked from network); 13 Jan 2021 22:31:27 -0000
Received: from lists.zx2c4.com (165.227.139.114)
  by inbox.vuxu.org with ESMTPUTF8; 13 Jan 2021 22:31:27 -0000
Received: 
	by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id ee00627e;
	Wed, 13 Jan 2021 22:31:09 +0000 (UTC)
Return-Path: <kian@kasad.com>
Received: from mail.kasad.com (mail.kasad.com
 [2001:19f0:5:46cc:5400:2ff:fed9:9eba])
 by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 45c1f446
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for <cgit@lists.zx2c4.com>;
 Wed, 13 Jan 2021 22:31:07 +0000 (UTC)
Received: from localhost (unknown [98.37.45.2])
 by mail.kasad.com (Postfix) with ESMTPSA id 68BC4220F6;
 Wed, 13 Jan 2021 14:31:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kasad.com; s=mail;
 t=1610577066; bh=IzIUa0xSEzwlXeA+V/68ExoEjBBDVctqnXOttunjNf0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=JgYomUbIW+j2ri20Ql+D4nXk7pYNX+VXvq+VsqPm9yy2ZIIB4z7LlppHUXBDRlcKZ
 OhIfiIq7ETA0nUeEFIWH/zXoezcBYge0Eb/gbyFymCby1jxCACyv0YhugO50Dwh3bg
 Q671GwtK0kYkMSSdgQCmP9We4h1tr0/jmJeeTpS86A2loI2C3KkGoR6GmJrzHcSX0n
 yRX5IMbEz0Uc1PPtmNXrg45ewRBlHxFGtj+WQWhmwfO/TM9CWZSIBdEvvRmAVof/j7
 VcCCVqbDNeDf0zsbIZ7dxaDtlhuNxnq1v3qTfDOqHA3Du6eZBNLpjbhK6V2/9CEXd5
 OPlLOiiglcoVw==
Date: Wed, 13 Jan 2021 14:31:05 -0800
From: Kian Kasad <kian@kasad.com>
To: Leroy van Logchem <lr.vanlogchem@gmail.com>
Cc: cgit@lists.zx2c4.com
Subject: Re: [Bug?] remove-suffix config position dependent
Message-ID: <20210113223105.ryv42xsjaphmpavc@frisbee>
References: <CAGoQ4UZemT0mxrMf7g+FPgt-eg-2EK5vqKBe3QFjzPdcxfCwrA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="twsh7whp2dvxrgy5"
Content-Disposition: inline
In-Reply-To: <CAGoQ4UZemT0mxrMf7g+FPgt-eg-2EK5vqKBe3QFjzPdcxfCwrA@mail.gmail.com>
X-BeenThere: cgit@lists.zx2c4.com
X-Mailman-Version: 2.1.30rc1
Precedence: list
List-Id: List for cgit developers and users <cgit.lists.zx2c4.com>
List-Unsubscribe: <https://lists.zx2c4.com/mailman/options/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=unsubscribe>
List-Archive: <http://lists.zx2c4.com/pipermail/cgit/>
List-Post: <mailto:cgit@lists.zx2c4.com>
List-Help: <mailto:cgit-request@lists.zx2c4.com?subject=help>
List-Subscribe: <https://lists.zx2c4.com/mailman/listinfo/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=subscribe>
Errors-To: cgit-bounces@lists.zx2c4.com
Sender: "CGit" <cgit-bounces@lists.zx2c4.com>


--twsh7whp2dvxrgy5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 21/01/13 11:24PM, Leroy van Logchem wrote:
> Setup
> =3D=3D=3D=3D=3D
> CGit v1.2.3 | https://git.zx2c4.com/cgit/
>=20
> Compiled in features:
> [+] Lua scripting
> [+] Linux sendfile() usage
>=20
> Issue
> =3D=3D=3D=3D
>=20
> remove-suffix=3D1 only works when defined _before_ the scan-path config i=
tem.
>=20
> Is this expected behavior?

Yes. It's listed in the documentation:
    remove-suffix::
        If set to "1" and scan-path is enabled, if any repositories are fou=
nd
        with a suffix of ".git", this suffix will be removed for the url and
        name. *This must be defined prior to scan-path*. Default value: "0".
        See also: scan-path.

--twsh7whp2dvxrgy5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRrgCQ5gHlZM+2U6fU7QHlES2ZOcgUCX/90pgAKCRA7QHlES2ZO
civdAP9BJ0N7nkUUJetwnAJq1S0Bno6Tekoc7TQdrZOH95viwQEAo+5hMbTih7Dm
wAJmqxqYL8w0jhZ3NFPa4zm4PH5xTQ8=
=2ujV
-----END PGP SIGNATURE-----

--twsh7whp2dvxrgy5--