List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH] cache: Tolerate short writes in print_slot
@ 2021-09-10 14:18 Hristo Venev
  0 siblings, 0 replies; only message in thread
From: Hristo Venev @ 2021-09-10 14:18 UTC (permalink / raw)
  To: cgit; +Cc: Hristo Venev

sendfile() can return after a short read/write, so we may need to call
it more than once. Furthermore, not all files support sendfile(), so we
may need to fall back to read/write.

On the read/write path, use write_in_full which deals with short writes.

Signed-off-by: Hristo Venev <hristo@venev.name>
---
 cache.c | 46 ++++++++++++++++++++++++----------------------
 1 file changed, 24 insertions(+), 22 deletions(-)

diff --git a/cache.c b/cache.c
index 55199e8..85cfbd9 100644
--- a/cache.c
+++ b/cache.c
@@ -85,40 +85,42 @@ static int close_slot(struct cache_slot *slot)
 /* Print the content of the active cache slot (but skip the key). */
 static int print_slot(struct cache_slot *slot)
 {
-#ifdef HAVE_LINUX_SENDFILE
-	off_t start_off;
-	int ret;
+	off_t off;
+	ssize_t i;
+
+	off = slot->keylen + 1;
 
-	start_off = slot->keylen + 1;
+#ifdef HAVE_LINUX_SENDFILE
+	off_t size;
+	size = slot->cache_st.st_size;
 
 	do {
-		ret = sendfile(STDOUT_FILENO, slot->cache_fd, &start_off,
-				slot->cache_st.st_size - start_off);
-		if (ret < 0) {
+		i = sendfile(STDOUT_FILENO, slot->cache_fd, &off, size - off);
+		if (i < 0) {
 			if (errno == EAGAIN || errno == EINTR)
 				continue;
+			/* Fall back to read/write on EINVAL */
+			if (errno == EINVAL)
+				break;
 			return errno;
 		}
-		return 0;
+		if (off == size)
+			return 0;
 	} while (1);
-#else
-	ssize_t i, j;
+#endif
 
-	i = lseek(slot->cache_fd, slot->keylen + 1, SEEK_SET);
-	if (i != slot->keylen + 1)
+	if (lseek(slot->cache_fd, off, SEEK_SET) != off)
 		return errno;
 
 	do {
-		i = j = xread(slot->cache_fd, slot->buf, sizeof(slot->buf));
-		if (i > 0)
-			j = xwrite(STDOUT_FILENO, slot->buf, i);
-	} while (i > 0 && j == i);
-
-	if (i < 0 || j != i)
-		return errno;
-	else
-		return 0;
-#endif
+		i = xread(slot->cache_fd, slot->buf, sizeof(slot->buf));
+		if (i < 0)
+			return errno;
+		if (i == 0)
+			return 0;
+		if (write_in_full(STDOUT_FILENO, slot->buf, i) < 0)
+			return errno;
+	} while (1);
 }
 
 /* Check if the slot has expired */
-- 
2.31.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-10 14:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-10 14:18 [PATCH] cache: Tolerate short writes in print_slot Hristo Venev

List for cgit developers and users

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/cgit

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 cgit cgit/ https://inbox.vuxu.org/cgit \
		cgit@lists.zx2c4.com
	public-inbox-index cgit

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.cgit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git