List for cgit developers and users
 help / color / mirror / Atom feed
From: Derek Stevens <nilix@nilfm.cc>
To: cgit@lists.zx2c4.com
Subject: Re: [PATCH] add 'go-import' meta tag if in a repo
Date: Sun, 9 Jan 2022 10:45:49 -0700	[thread overview]
Message-ID: <20220109174549.qjdox4wuav3mxtci@ksatrya.siroonian.local> (raw)

[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]

Ok, I'll see about adding a config option and corresponding documentation for this, as well as make sure that my indentation is consistent.

Thanks!
Derek

------original message------
From: Jamie Couture <jamie.couture@gmail.com>
Date: Sun, Jan 09, 2022 at 09:59:04AM MST

> On Sat, Jan 08, 2022 at 04:55:59PM -0700, Derek Stevens wrote:
> > Signed-off-by: Derek Stevens <nilix@nilfm.cc>
> > ---
> > ui-shared.c | 3 +++
> > 1 file changed, 3 insertions(+)
> > 
> > diff --git a/ui-shared.c b/ui-shared.c
> > index acd8ab5..0f57af6 100644
> > --- a/ui-shared.c
> > +++ b/ui-shared.c
> > @@ -785,6 +785,9 @@ void cgit_print_docstart(void)
> > 	html_txt(ctx.page.title);
> > 	html("</title>\n");
> > 	htmlf("<meta name='generator' content='cgit %s'/>\n", cgit_version);
> > +	if (ctx.repo)
> I recommend making this an optional feature people can opt-in and use.  
> Consider adding a configuration flag [1] and supporting documentation [2],
> allowing admins to turn a knob 'on' if they want to use this feature.
> 
> As John pointed out a minor nit: the leading whitespace should be tabs, 
> whereas these lines are mixed tab-and-space..
> 
> > +	  htmlf("<meta name='go-import' content='%s%s%s git https://%s%s%s'/>\n",
> > +	    host, cgit_rooturl(), ctx.repo->url, host, cgit_rooturl(), ctx.repo->url);
> > 	if (ctx.cfg.robots && *ctx.cfg.robots)
> > 		htmlf("<meta name='robots' content='%s'/>\n", ctx.cfg.robots);
> > 	html("<link rel='stylesheet' type='text/css' href='");
> > -- 
> > 2.34.1
> > 
> 
> --
> 
> [1] https://git.zx2c4.com/cgit/tree/cgit.c#n42
> [2] https://git.zx2c4.com/cgit/tree/cgitrc.5.txt



----- End forwarded message -----

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2022-01-09 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-09 17:45 Derek Stevens [this message]
     [not found] ` <dc347023-fb80-4c44-b75a-1fd2b05e463c@www.fastmail.com>
2022-05-09 14:57   ` Derek Stevens
  -- strict thread matches above, loose matches on Subject: below --
2022-01-08 23:55 Derek Stevens
2022-01-09 14:23 ` John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220109174549.qjdox4wuav3mxtci@ksatrya.siroonian.local \
    --to=nilix@nilfm.cc \
    --cc=cgit@lists.zx2c4.com \
    --subject='Re: [PATCH] add '\''go-import'\'' meta tag if in a repo' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).