From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9883 invoked from network); 9 Jan 2022 17:46:14 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 9 Jan 2022 17:46:14 -0000 Received: by lists.zx2c4.com (OpenSMTPD) with ESMTP id ce641b00; Sun, 9 Jan 2022 17:45:57 +0000 (UTC) Return-Path: Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) by lists.zx2c4.com (OpenSMTPD) with ESMTPS id 6a677e64 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Sun, 9 Jan 2022 17:45:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1641750351; cv=none; d=zohomail.com; s=zohoarc; b=IIXkwgJnlrlWb/MWsgai/Cie/aAUVyLXKSuOoOY+QZg6H32Dw9EEE4OlDwJjj5JULEwiNUXN94HqCcvaJl98bUmhl2l+dMuD3A0h9XqLr5u/ByomkPERMpClWZbgyARp8M5VqKlEo8gFUkxv9YYhyEUyJwUUNqzZ9lSzmCkrktk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641750351; h=Content-Type:Date:From:MIME-Version:Message-ID:Subject:To; bh=N66dINQ9bEW0NudpNQ/IInQ77mJhf3N+biCjDwsKSoA=; b=XLyTb25bJQ0ADXIop+pv4vva0H7F5q4AePh/ST1rAN3QwMl/jL2C4WcgntqxJipyAKyFpVfFc+SCg7XQiIIIJYGwOsLiNyGZWiaL/lzKh5bPz1fbpNp5W8j0PDrZafBwT1tVSjgPpYrEzphEZrQRhPZ3oJoBHoO7kP6zjxalMeQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=nilfm.cc; spf=pass smtp.mailfrom=nilix@nilfm.cc; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1641750351; s=zoho; d=nilfm.cc; i=nilix@nilfm.cc; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; bh=N66dINQ9bEW0NudpNQ/IInQ77mJhf3N+biCjDwsKSoA=; b=P3jpSCUSKwkPtrm2xYXflQ+we+sNOQ29VMlAJ6f/sTvGbCKc+RMEHkim5Fa0udMs WsFruKfdrGJou/Wo4wLu1h+iM5Sz+qgJSqXNgSic4knIhj/UHO+Vth9Pn9oEkQaj6RY N9ZCauBSIUah1Xga1YRgWv5OpyVzg9xJ+wtObAHY= Received: from ksatrya.siroonian.local (c-76-127-49-136.hsd1.nm.comcast.net [76.127.49.136]) by mx.zohomail.com with SMTPS id 1641750350053161.69171646453378; Sun, 9 Jan 2022 09:45:50 -0800 (PST) Date: Sun, 9 Jan 2022 10:45:49 -0700 From: Derek Stevens To: cgit@lists.zx2c4.com Subject: Re: [PATCH] add 'go-import' meta tag if in a repo Message-ID: <20220109174549.qjdox4wuav3mxtci@ksatrya.siroonian.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="modlbdygwiioihqy" Content-Disposition: inline X-Zoho-Virus-Status: 1 X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" --modlbdygwiioihqy Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Ok, I'll see about adding a config option and corresponding documentation f= or this, as well as make sure that my indentation is consistent. Thanks! Derek ------original message------ =46rom: Jamie Couture Date: Sun, Jan 09, 2022 at 09:59:04AM MST > On Sat, Jan 08, 2022 at 04:55:59PM -0700, Derek Stevens wrote: > > Signed-off-by: Derek Stevens > > --- > > ui-shared.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/ui-shared.c b/ui-shared.c > > index acd8ab5..0f57af6 100644 > > --- a/ui-shared.c > > +++ b/ui-shared.c > > @@ -785,6 +785,9 @@ void cgit_print_docstart(void) > > html_txt(ctx.page.title); > > html("\n"); > > htmlf("\n", cgit_version= ); > > + if (ctx.repo) > I recommend making this an optional feature people can opt-in and use. = =20 > Consider adding a configuration flag [1] and supporting documentation [2], > allowing admins to turn a knob 'on' if they want to use this feature. >=20 > As John pointed out a minor nit: the leading whitespace should be tabs,= =20 > whereas these lines are mixed tab-and-space.. >=20 > > + htmlf("\n", > > + host, cgit_rooturl(), ctx.repo->url, host, cgit_rooturl(), ctx.re= po->url); > > if (ctx.cfg.robots && *ctx.cfg.robots) > > htmlf("\n", ctx.cfg.robots); > > html(" > --=20 > > 2.34.1 > >=20 >=20 > -- >=20 > [1] https://git.zx2c4.com/cgit/tree/cgit.c#n42 > [2] https://git.zx2c4.com/cgit/tree/cgitrc.5.txt ----- End forwarded message ----- --modlbdygwiioihqy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEkFh6dA+k/6CXFXU4O3+8IhROY5gFAmHbH0sACgkQO3+8IhRO Y5i06A//cC2jRqr+I3PT9Y7z0R4t7BCU25M7Ime4U5cS4to7Lu0cMN2iU5g8imZc b3Iood9FUD2yh9TzmhvaudSIsjAJoQ+7usLAV741w+A3BzV9NWMXiCGSzlzpgFha VvfkHYzXY2JElBidZSGEhd7y9cHtBPX4FckVWd9EMFFt0CGCpGKnL3y1S9RtN8do Zc+KBE8gHZwzgBs/xWUz8CgCaOAPALwK1GpOI6JkMcJF+WIdceZAcG0zHcKzKwid ufjYZEIOc654oU2JAFWClnvy05OzMnTqZloXrBspXXYr1Kl9WRUIkdqYtER6pbR3 z5U41ZglKGJ2pM/xrH168CPMeX0aXFDrEhK9KKOG3NK+Uys5K0KqC1H1+Yq5tAhW TuXtWiLo0hTJaE5yJkrUvyjoVV309/qT2HZwZhehB3lIVfGGOuktVuGyROCgd9Mq UTRe2+Jm4lt93OT9Uij1CX0Khm2zz7WNuXnPGgPWfC6mIXx5XsCTp5ptrQcQBy+n 3AdS/FCyeBmVsNDcF8D/tJn8uLQ0Aa427Wpu/0APsSVSxbwFdlwt85rPoLuaAC6w AllxrlyJ3dFloBRxlW9hvG9muVV5TW2MJZC7JGvUy/F7fckHYj49QQLd3EDLmFme rX3HLDWwL2w1EHnIR8yBl+kQD1/AlrFOKrthk6Bf6ArOODN9p3k= =ejqF -----END PGP SIGNATURE----- --modlbdygwiioihqy--