From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 6099 invoked from network); 12 Jan 2023 00:33:25 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 12 Jan 2023 00:33:25 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id a844b4bc; Thu, 12 Jan 2023 00:33:08 +0000 (UTC) Return-Path: Received: from smtpout-53.fbg1.glesys.net (smtpout-53.fbg1.glesys.net [2a02:751:100:2::53]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 3fc45215 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Thu, 12 Jan 2023 00:33:07 +0000 (UTC) X-Sender-ID: ae47c1f9-9210-11ed-839b-3b1133bf5501 Date: Thu, 12 Jan 2023 01:33:05 +0100 From: Samuel =?ISO-8859-1?Q?Lid=E9n?= Borell To: cgit@lists.zx2c4.com Subject: Re: [PATCH RESEND v2] css: Support for dark mode Message-Id: <20230112013305.0b5ccab36a3a81330f91f371@kodafritt.se> In-Reply-To: References: <20230101214103.1E52F19A2@badger.kodafritt.se> <20230105225343.0264A262C@badger.kodafritt.se> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; aarch64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" Oops. I made a last minute change of the themes, and that broke things. Looks like some theme combinations don't work well. I will send an updated patch with a working theme combo + a comment about this. It could also be solved by also wrapping the light theme in a media query, but then older browsers will not show the highlighting. Regards, Samuel On Wed, 11 Jan 2023 21:56:30 +0100, "Jason A. Donenfeld" wrote: > It looks like the issue is that the string class for the light theme is: > > .highlight .s { > color: #dd2200; > background-color: #fff0f0; > } > > But for the dark theme it's: > > @media (prefers-color-scheme: dark) > .highlight .s { > color: #e6db74; > } > > And so it winds up using the dark color, but with the light > background, because the dark theme doesn't specify a background.