From: "Samuel Lidén Borell" <samuel@kodafritt.se>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: cgit@lists.zx2c4.com
Subject: Re: [PATCH v3] css: Support for dark mode
Date: Sun, 29 Jan 2023 18:07:50 +0100 [thread overview]
Message-ID: <20230129180750.c20b661a91bb26447422c66c@kodafritt.se> (raw)
In-Reply-To: <CAHmME9qmfbk5bg7Gye7Dks_ci+BoYUrbezt46YuJp-nfV9cCYA@mail.gmail.com>
On Fri, 27 Jan 2023 14:42:58 -0600, "Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
> It still feels like the table shading is now way too dark in dark
> mode. For all those various grays, there might be some transformation
> to consider where you want the same distance from black that it
> formerly had from white.
Good point. I've fixed this and I will send v4 shortly. It is the same distance now (in the RGB value). Other improvements:
* The .list table background is fixed.
* Support for non-media-query-supporting browsers in syntax-highlight.sh also.
I agree it would be nice to have an automatic transformation, i.e. darkcolor=f(lightcolor). Unfortunately I don't know how to do that. Color is a quite tricky subject because RGB is non-linear, and some colors (e.g. green #00ff00) are perceived as brigther than others (e.g. blue #0000ff). In fact, v1 of the patch was simply an inversion + re-sorting of the RGB components (to preserve nuance), and the looks of that was sub-optimal.
Regards,
Samuel
next prev parent reply other threads:[~2023-01-29 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 21:15 [PATCH] css: Optional support " Samuel Lidén Borell
2023-01-02 0:51 ` Jason A. Donenfeld
2023-01-01 21:15 ` [PATCH RESEND v2] css: Support " Samuel Lidén Borell
2023-01-11 20:54 ` Jason A. Donenfeld
2023-01-11 20:56 ` Jason A. Donenfeld
2023-01-12 0:33 ` Samuel Lidén Borell
2023-01-12 0:34 ` Jason A. Donenfeld
2023-01-12 0:33 ` Jason A. Donenfeld
2023-01-22 11:35 ` [PATCH v3] " Samuel Lidén Borell
2023-01-22 13:04 ` Samuel Lidén Borell
2023-01-27 20:42 ` Jason A. Donenfeld
2023-01-29 17:07 ` Samuel Lidén Borell [this message]
2023-01-29 16:55 ` [PATCH v4] " Samuel Lidén Borell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230129180750.c20b661a91bb26447422c66c@kodafritt.se \
--to=samuel@kodafritt.se \
--cc=Jason@zx2c4.com \
--cc=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).