From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.4 required=5.0 tests=MAILING_LIST_MULTI,
	NICE_REPLY_A,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no
	version=3.4.4
Received: (qmail 8341 invoked from network); 29 Jan 2023 17:08:11 -0000
Received: from lists.zx2c4.com (165.227.139.114)
  by inbox.vuxu.org with ESMTPUTF8; 29 Jan 2023 17:08:11 -0000
Received: 
	by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 8a94bd91;
	Sun, 29 Jan 2023 17:07:53 +0000 (UTC)
Return-Path: <samuel@kodafritt.se>
Received: from smtpout-37.fbg1.glesys.net (smtpout-37.fbg1.glesys.net
 [2a02:751:100:1::37])
 by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 309bdfa7
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <cgit@lists.zx2c4.com>;
 Sun, 29 Jan 2023 17:07:52 +0000 (UTC)
X-Sender-ID: 763a942a-9ff7-11ed-8498-371c8b8afd02
Date: Sun, 29 Jan 2023 18:07:50 +0100
From: Samuel =?ISO-8859-1?Q?Lid=E9n?= Borell <samuel@kodafritt.se>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: cgit@lists.zx2c4.com
Subject: Re: [PATCH v3] css: Support for dark mode
Message-Id: <20230129180750.c20b661a91bb26447422c66c@kodafritt.se>
In-Reply-To: <CAHmME9qmfbk5bg7Gye7Dks_ci+BoYUrbezt46YuJp-nfV9cCYA@mail.gmail.com>
References: <Y79VbkfCTvyvYUGv@zx2c4.com>
 <20230122122519.3D50F13F@badger.kodafritt.se>
 <CAHmME9qmfbk5bg7Gye7Dks_ci+BoYUrbezt46YuJp-nfV9cCYA@mail.gmail.com>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; aarch64-unknown-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: cgit@lists.zx2c4.com
X-Mailman-Version: 2.1.30rc1
Precedence: list
List-Id: List for cgit developers and users <cgit.lists.zx2c4.com>
List-Unsubscribe: <https://lists.zx2c4.com/mailman/options/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=unsubscribe>
List-Archive: <http://lists.zx2c4.com/pipermail/cgit/>
List-Post: <mailto:cgit@lists.zx2c4.com>
List-Help: <mailto:cgit-request@lists.zx2c4.com?subject=help>
List-Subscribe: <https://lists.zx2c4.com/mailman/listinfo/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=subscribe>
Errors-To: cgit-bounces@lists.zx2c4.com
Sender: "CGit" <cgit-bounces@lists.zx2c4.com>

On Fri, 27 Jan 2023 14:42:58 -0600, "Jason A. Donenfeld" <Jason@zx2c4.com> wrote:

> It still feels like the table shading is now way too dark in dark
> mode. For all those various grays, there might be some transformation
> to consider where you want the same distance from black that it
> formerly had from white.

Good point. I've fixed this and I will send v4 shortly. It is the same distance now (in the RGB value). Other improvements:
* The .list table background is fixed.
* Support for non-media-query-supporting browsers in syntax-highlight.sh also.

I agree it would be nice to have an automatic transformation, i.e. darkcolor=f(lightcolor). Unfortunately I don't know how to do that. Color is a quite tricky subject because RGB is non-linear, and some colors (e.g. green #00ff00) are perceived as brigther than others (e.g. blue #0000ff). In fact, v1 of the patch was simply an inversion + re-sorting of the RGB components (to preserve nuance), and the looks of that was sub-optimal.

Regards,
Samuel