From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14618 invoked from network); 26 May 2023 14:21:26 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 26 May 2023 14:21:26 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 20c07913; Fri, 26 May 2023 14:21:15 +0000 (UTC) Return-Path: Received: from mx.mylinuxtime.de (mx.mylinuxtime.de [2a01:4f8:13a:16c2::25]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id ffe29833 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 26 May 2023 14:21:14 +0000 (UTC) Received: from leda.eworm.net (unknown [185.209.196.154]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx.mylinuxtime.de (Postfix) with ESMTPSA id 63588229966; Fri, 26 May 2023 16:21:14 +0200 (CEST) Date: Fri, 26 May 2023 16:21:13 +0200 From: Christian Hesse To: "Jason A. Donenfeld" Cc: cgit@lists.zx2c4.com, Christian Hesse Subject: Re: [PATCH 1/1] RFC: git: update to v2.41.0-rc2 Message-ID: <20230526162113.0c8763c3@leda.eworm.net> In-Reply-To: References: <20230526110646.60621-1-list@eworm.de> <20230526160653.7962c827@leda.eworm.net> <20230526161735.57ebdc54@leda.eworm.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) X-Face: %O:rCSkHSKf7^4uF|FD$9$I0}g$nbnS1{DYPvs#:,~e`).mzj\$P9]V!WCveE/XdbL,L!{)6v%x4\Bt!b#{; dS&h"7l=ow'^({02!2%XOugod|u*mYBVm-OS:VpZ"ZrRA4[Q&zye,^j; ftj!Hxx\1@; LM)Pz)|B%1#sfF; s; ,N?*K*^) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUZFRFENy6KVTKEd23CiGHeqofJvrX4+vdHgItOAAAACXBIWXMAAA3XAAAN1wFCKJt4AAACUklEQVQ4y2VUTZeqMAxNxXG2Io5uGd64L35unbF9ax0b3OLxgFs4PcLff0lBHeb1QIq5uelNCEJNq/TIFGyeC+iugH0WJr+B1MvzWASpuP4CYHOB0VfoDdddwA7OIFQIEHjXDiCtV5e9QX0WMu8AG0mB7g7WP4GqeqVdsi4vv/5kFBvaF/zD7zDquL4DxbrDGDyAsgNYOsJOYzth4Q9ZF6iLV+6TLAT1pi2kuvgAtZxSjoG8cL+8vIn251uoe1OOEWwbIPU04gHsmMsoxyyhYsD2FdIigF1yxaVbBuSOCAlCoX324I7wNMhrO1bhOLsRoA6DC6wQ5eQiSG5BiWQfM4gN+uItQTRDMaJUhVbGyKWCuaaUGSVFVKpl4PdoDn3yY8J+YxQxyhlHfoYOyPgyDcO+cSQK6Bvabjcy2nwRo3pxgA8jslnCuYw23ESOzHAPYwo4ITNQMaOO+RGPEGhSlPEZBh2jmBEjQ5cKbxmr0ruAe/WCriUxW76I8T3h7vqY5VR5wXLdERodg2rHEzdxxk5KpXTL4FwnarvndKM5/MWDY5CuBBdQ+3/0ivsUJHicuHd+Xh3jOdBL+FjSGq4SPCwco+orpWlERRTNo7BHCvbNXFVSIQMp+P5QsIL9upmr8kMTUOfxEHoanwzKRcNAe76WbjBwex/RkdHu48xT5YqP70DaMOhBcTHmAVDxLaBdle93oJy1QKFUh2GXT4am+YH/GGel1CeI98GdMXsytjCKIq/9cMrlgxFCROv+3/BU1fijNpcVD6DxE8VfLBaxUGr1D5usgDYdjwiPAAAAAElFTkSuQmCC MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/6mIOVc5fPpYe9vlP_hasNXu"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" --Sig_/6mIOVc5fPpYe9vlP_hasNXu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable "Jason A. Donenfeld" on Fri, 2023/05/26 16:18: > On Fri, May 26, 2023 at 4:17=E2=80=AFPM Christian Hesse w= rote: > > > > Christian Hesse on Fri, 2023/05/26 16:06: =20 > > > > Like string_list_split(), except that string is split in-place: the > > > > delimiter characters in string are overwritten with NULs, and the > > > > new string_list_items point into string (which therefore must not > > > > be modified or freed while the string_list is in use). > > > > list->strdup_strings must *not* be set. =20 > > > > > > So we should be fine with the change, no? =20 > > > > Ah, the strings are not allocated, but we should run: > > > > string_list_clear(&list, 0); > > > > Is it fine then? =20 >=20 > Right. My understanding is that while the strings themselves are not > allocated, the array of string list items still is. Probably. But is there a better alternative now that `strtok_r()` is banne= d? --=20 main(a){char*c=3D/* Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/* Best regards my address: */=3D0;b=3Dc[a+= +];) putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);} --Sig_/6mIOVc5fPpYe9vlP_hasNXu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEXHmveYAHrRp+prOviUUh18yA9HYFAmRwwFkACgkQiUUh18yA 9HaLTAgAvT0NJQdQTuxCh7/gMsqDui4l8VEipxZp/X9gU7RO1y62anUUtzyNMAzZ UV9Div98uNv/D6Xep4oZYJdQ5Vdn7vou3aqFgJYFILxF0LxJ6dIc6Qh6vfQ7PMoo DKLJgGlTj1XydCIu0MX0eNF3GHRv8nu/haRoM+SUuLQ+odOnENyJh6FihnM+Eb4R 68dQA65VpRD1Cyh7Dk/OkKjSonyN7XHXqsUE07BNOwA1El1oDnYAR1FllKbQiVHY tdLNHzno8N4nEaSDuvsMRpZgSBsyjj705z90LQs4z1cSiwYpGqcN8rr7LFD2kp/u PmZyJsSK7xVZu6OrxqDzlCQk+hT8/w== =TneA -----END PGP SIGNATURE----- --Sig_/6mIOVc5fPpYe9vlP_hasNXu--